adm: Make --namespace flag required #1026

achuprov · 2024-03-05T12:11:06Z

achuprov commented

2024-03-05 12:11:06 +00:00

Before:

./bin/frostfs-adm morph frostfsid create-namespace --alphabet-wallets dev/ir/ --rpc-endpoint http:/
/morph-chain.frostfs.devenv:30333 
Password for az wallet > 
create namespace error: could not perform test invocation: script failed (FAULT state) due to an error: at instruction 2839 (THROW): unhandled exception: "namespace already exists"

After:

./bin/frostfs-adm morph frostfsid create-namespace --alphabet-wallets dev/ir/ --rpc-endpoint http://morph-chain.frostfs.devenv:30333 
Error: required flag(s) "namespace" not set

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1023 Before: ``` ./bin/frostfs-adm morph frostfsid create-namespace --alphabet-wallets dev/ir/ --rpc-endpoint http:/ /morph-chain.frostfs.devenv:30333 Password for az wallet > create namespace error: could not perform test invocation: script failed (FAULT state) due to an error: at instruction 2839 (THROW): unhandled exception: "namespace already exists" ``` After: ``` ./bin/frostfs-adm morph frostfsid create-namespace --alphabet-wallets dev/ir/ --rpc-endpoint http://morph-chain.frostfs.devenv:30333 Error: required flag(s) "namespace" not set ``` Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

achuprov changed title from ~~[#1023] adm: Make --namespace flag required~~ to adm: Make --namespace flag required

2024-03-05 12:11:37 +00:00

achuprov force-pushed bugfix/namespace_require from fca213a7af to 577aad40b7

2024-03-05 12:14:00 +00:00

Compare

achuprov requested review from storage-core-developers 2024-03-05 12:30:41 +00:00

achuprov requested review from storage-core-committers 2024-03-05 12:30:42 +00:00

fyrchik approved these changes 2024-03-05 12:34:03 +00:00

cmd/frostfs-adm/internal/modules/morph/frostfsid/frostfsid.go Outdated

													
				@ -155,6 +155,7 @@ func initFrostfsIDCreateNamespaceCmd() {

					frostfsidCreateNamespaceCmd.Flags().StringP(commonflags.EndpointFlag, commonflags.EndpointFlagShort, "", commonflags.EndpointFlagDesc)

					frostfsidCreateNamespaceCmd.Flags().String(namespaceFlag, "", "Namespace name to create")

					frostfsidCreateNamespaceCmd.Flags().String(commonflags.AlphabetWalletsFlag, "", commonflags.AlphabetWalletsFlagDesc)

					_ = frostfsidCreateNamespaceCmd.MarkFlagRequired(namespaceFlag)

fyrchik commented

2024-03-05 12:33:26 +00:00

It should be required only for create-namespace, other commands can use root namespace by default (which is, quite conveniently, also an empty string).
cc @aarifullin

It should be required only for `create-namespace`, other commands can use `root` namespace by default (which is, quite conveniently, also an empty string). cc @aarifullin

👍 1

fyrchik commented

2024-03-05 12:34:00 +00:00

Other operations should pass on dev-env without namespace, could you recheck this?