TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 8 Projects Releases 1 Activity Actions

adm: Make --namespace flag required #1026

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:bugfix/namespace_require into master 2024-03-05 18:40:50 +00:00
Conversation 0 Commits 1 Files changed 1 +1
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
cmd/frostfs-adm/internal/modules/morph/frostfsid/frostfsid.go
View file

@ -155,6 +155,7 @@ func initFrostfsIDCreateNamespaceCmd() {
frostfsidCreateNamespaceCmd.Flags().StringP(commonflags.EndpointFlag, commonflags.EndpointFlagShort, "", commonflags.EndpointFlagDesc) frostfsidCreateNamespaceCmd.Flags().StringP(commonflags.EndpointFlag, commonflags.EndpointFlagShort, "", commonflags.EndpointFlagDesc)
frostfsidCreateNamespaceCmd.Flags().String(namespaceFlag, "", "Namespace name to create") frostfsidCreateNamespaceCmd.Flags().String(namespaceFlag, "", "Namespace name to create")
frostfsidCreateNamespaceCmd.Flags().String(commonflags.AlphabetWalletsFlag, "", commonflags.AlphabetWalletsFlagDesc) frostfsidCreateNamespaceCmd.Flags().String(commonflags.AlphabetWalletsFlag, "", commonflags.AlphabetWalletsFlagDesc)
_ = frostfsidCreateNamespaceCmd.MarkFlagRequired(namespaceFlag)
fyrchik commented 2024-03-05 12:33:26 +00:00
Outdated
Review
Copy link

It should be required only for create-namespace, other commands can use root namespace by default (which is, quite conveniently, also an empty string).
cc @aarifullin

It should be required only for `create-namespace`, other commands can use `root` namespace by default (which is, quite conveniently, also an empty string). cc @aarifullin
👍 1
fyrchik commented 2024-03-05 12:34:00 +00:00
Outdated
Review
Copy link

Other operations should pass on dev-env without namespace, could you recheck this?

Other operations should pass on dev-env without namespace, could you recheck this?
} }
func initFrostfsIDListNamespacesCmd() { func initFrostfsIDListNamespacesCmd() {