TrueCloudLab/frostfs-node

Fork 27

Revert asynchronous waitNotaryDeposit running but keep logs #1042

Merged

acid-ant merged 1 commit from aarifullin/frostfs-node:fix/revert_async_notary_deposit into master

2024-09-04 19:51:07 +00:00

aarifullin commented

2024-03-13 09:03:53 +00:00

Member

Revert "[#963] node: Go on initialization even deposit notary is hung"
Keep logging for waitNotaryDeposit

The commit is reverted because if a storage node didn't make notary deposit yet, then bootstrapNode fails with

024-03-13T07:34:32.828Z        INFO    Error encountered with rpc request      {"code": -500, "cause": "fallback transaction is valid after deposit is unlocked: ValidUntilBlock is 100, deposit lock for NejLbQpojKJWec4NQRMBhzsrmCyhXfGJJe expires at 0", "method": "submitnotaryrequest", "params": "[AEC022HMdBkAAAAAAMLMeAIAAAAAZAAAAAQfoIPc6KAwKUX82xtlmXa4rvfuA4DYzFqQTVJvyabKtVugLJpv54nJViEBArNiK/QBe9/jF8WK7V9MdT8ga324lgRvp9d0u8S/f43Czm...w==]"}

- Revert "[#963] node: Go on initialization even deposit notary is hung" - Keep logging for `waitNotaryDeposit` The commit is reverted because if a storage node didn't make notary deposit yet, then `bootstrapNode` fails with ```bash 024-03-13T07:34:32.828Z INFO Error encountered with rpc request {"code": -500, "cause": "fallback transaction is valid after deposit is unlocked: ValidUntilBlock is 100, deposit lock for NejLbQpojKJWec4NQRMBhzsrmCyhXfGJJe expires at 0", "method": "submitnotaryrequest", "params": "[AEC022HMdBkAAAAAAMLMeAIAAAAAZAAAAAQfoIPc6KAwKUX82xtlmXa4rvfuA4DYzFqQTVJvyabKtVugLJpv54nJViEBArNiK/QBe9/jF8WK7V9MdT8ga324lgRvp9d0u8S/f43Czm...w==]"} ```

aarifullin added the

frostfs-node

label 2024-03-13 09:03:53 +00:00

aarifullin added 2 commits 2024-03-13 09:03:57 +00:00

Revert "[#963 ] node: Go on initialization even deposit notary is hung" 7a4b6057ce

This reverts commit b4cb54e7ed.

Signed-off-by: aarifullin <a.arifullin@yadro.com>

[#963 ] node: Add logging for waitNotaryDeposit

DCO action / DCO (pull_request) Successful in 2m19s

Details

Vulncheck / Vulncheck (pull_request) Successful in 3m13s

Details

Build / Build Components (1.21) (pull_request) Successful in 4m13s

Details

Build / Build Components (1.20) (pull_request) Successful in 4m18s

Details

Tests and linters / Staticcheck (pull_request) Successful in 5m57s

Details

Tests and linters / Lint (pull_request) Successful in 6m31s

Details

Tests and linters / gopls check (pull_request) Successful in 7m11s

Details

Tests and linters / Tests (1.20) (pull_request) Successful in 9m42s

Details

Tests and linters / Tests (1.21) (pull_request) Successful in 10m30s

Details

Tests and linters / Tests with -race (pull_request) Successful in 10m33s

Details

d1d53d2bb6

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

aarifullin requested review from storage-core-committers 2024-03-13 09:04:05 +00:00

aarifullin requested review from storage-core-developers 2024-03-13 09:04:12 +00:00

fyrchik approved these changes 2024-03-13 09:05:16 +00:00

dstepanov-yadro approved these changes 2024-03-13 09:05:39 +00:00

acid-ant approved these changes 2024-03-13 09:29:41 +00:00

acid-ant merged commit d1d53d2bb6 into master

2024-03-13 09:30:34 +00:00

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1042

No description provided.