TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

WIP: Fix infinite sort RPC #1068

Closed
alexvanin wants to merge 3 commits from alexvanin/frostfs-node:fix/infinite-forest-sort into master
pull from: alexvanin/frostfs-node:fix/infinite-forest-sort
merge into: TrueCloudLab:master
Conversation 2 Commits 3 Files changed 2 +17 -3
alexvanin commented 2024-04-01 18:06:04 +00:00
Owner
Copy link

While testing s3-gw with #1059 fix, I noticed RPC loop during tree streaming.
Turns out, storage node returned the same tree element without EOF.
It was triggered due to invalid condition for regular sorting. This PR fixes it.

While testing s3-gw with #1059 fix, I noticed RPC loop during tree streaming. Turns out, storage node returned the same tree element without EOF. It was triggered due to invalid condition for regular sorting. This PR fixes it.
alexvanin requested review from fyrchik 2024-04-01 18:06:21 +00:00
alexvanin requested review from dstepanov-yadro 2024-04-01 18:06:21 +00:00
alexvanin force-pushed fix/infinite-forest-sort from 77ee5c2164 to b595ba2992 2024-04-01 18:09:52 +00:00 Compare
acid-ant approved these changes 2024-04-01 18:40:37 +00:00
alexvanin added 1 commit 2024-04-02 05:45:40 +00:00
[#1059] pilorama: Pass linter check
All checks were successful
DCO action / DCO (pull_request) Successful in 1m16s
Details
Build / Build Components (1.21) (pull_request) Successful in 3m16s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m35s
Details
Build / Build Components (1.20) (pull_request) Successful in 5m8s
Details
Tests and linters / gopls check (pull_request) Successful in 6m42s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m48s
Details
Tests and linters / Lint (pull_request) Successful in 7m25s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 8m34s
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m43s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m5s
Details
ed2377307d 
funlen 'TreeSortedByFilename' is too long (81 > 80)

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
alexvanin commented 2024-04-02 06:12:13 +00:00
Author
Owner
Copy link

Seems like there are more issues, setting WIP.

Seems like there are more issues, setting WIP.
alexvanin changed title from Fix infinite sort RPC to WIP: Fix infinite sort RPC 2024-04-02 06:12:25 +00:00
fyrchik commented 2024-04-02 12:03:42 +00:00
Owner
Copy link

Closing in favor of #1070

Closing in favor of #1070
fyrchik closed this pull request 2024-04-02 12:03:44 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 1m16s
Required
Details
Build / Build Components (1.21) (pull_request) Successful in 3m16s
Required
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m35s
Required
Details
Build / Build Components (1.20) (pull_request) Successful in 5m8s
Required
Details
Tests and linters / gopls check (pull_request) Successful in 6m42s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m48s
Required
Details
Tests and linters / Lint (pull_request) Successful in 7m25s
Required
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 8m34s
Required
Details
Tests and linters / Tests with -race (pull_request) Successful in 8m43s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m5s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1068
No description provided.
Delete branch "alexvanin/frostfs-node:fix/infinite-forest-sort"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?