TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

node: Implement Range\RangeHash requests for EC object #1112

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:feature/ec-range-hash into master 2024-09-04 19:51:08 +00:00
Conversation 1 Commits 1 Files changed 2 +2 -1
acid-ant commented 2024-04-27 20:11:33 +00:00
Member
Copy link

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/ec-range-hash from c9103ddcc2 to ecf03fc548 2024-04-27 20:12:14 +00:00 Compare
acid-ant changed title from node: Implement Range\RangeHash requests for EC object to WIP: node: Implement Range\RangeHash requests for EC object 2024-04-30 09:47:10 +00:00
acid-ant force-pushed feature/ec-range-hash from ecf03fc548 to 960b025aaa 2024-05-02 11:37:58 +00:00 Compare
acid-ant force-pushed feature/ec-range-hash from 960b025aaa to f08b453247 2024-05-02 12:04:25 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-05-02 16:45:59 +00:00
acid-ant requested review from storage-core-developers 2024-05-02 16:45:59 +00:00
acid-ant changed title from WIP: node: Implement Range\RangeHash requests for EC object to node: Implement Range\RangeHash requests for EC object 2024-05-02 16:46:05 +00:00
acid-ant reviewed 2024-05-02 16:46:44 +00:00
acid-ant force-pushed feature/ec-range-hash from 6958163277 to bba0bd8161 2024-05-02 17:26:33 +00:00 Compare
dstepanov-yadro reviewed 2024-05-03 07:42:52 +00:00
pkg/services/object/get/assemblerec.go Outdated
@ -75,0 +82,4 @@
if err == nil {
err = writer.WriteChunk(ctx, obj.Payload())
if err != nil {
return nil, err
dstepanov-yadro commented 2024-05-03 07:42:52 +00:00
Member
Copy link

Looks too complex:

if err == nil {
    if a.rng != nil {
...
    } else {
        if err == nil {
            if err != nil {
            }
        }
    }
}

No need to fix. I will see if it is possible to make linter stricker.

Looks too complex: ``` if err == nil { if a.rng != nil { ... } else { if err == nil { if err != nil { } } } } ``` No need to fix. I will see if it is possible to make linter stricker.
👍 1
acid-ant commented 2024-05-03 12:35:55 +00:00
Author
Member
Copy link

Refactored a bit. Now it is possible to optimize range request separately.

Refactored a bit. Now it is possible to optimize range request separately.
dstepanov-yadro approved these changes 2024-05-03 07:42:58 +00:00
fyrchik reviewed 2024-05-03 10:03:57 +00:00
.pre-commit-config.yaml Outdated
@ -17,3 +17,3 @@
args: [--markdown-linebreak-ext=md]
- id: end-of-file-fixer
exclude: "(.key|.svg)$"
exclude: "(.key|.svg|.puml)$"
fyrchik commented 2024-05-02 17:48:24 +00:00
Owner
Copy link

puml is ok, it is not autogenerated, why did you add it?

puml is ok, it is not autogenerated, why did you add it?
acid-ant commented 2024-05-03 12:34:47 +00:00
Author
Member
Copy link

It is boring to fix the end of file issue again and again. Reverted this change.

It is boring to fix the end of file issue again and again. Reverted this change.
fyrchik commented 2024-05-06 05:23:35 +00:00
Owner
Copy link

#1118

https://git.frostfs.info/TrueCloudLab/frostfs-node/issues/1118
acid-ant force-pushed feature/ec-range-hash from bba0bd8161 to af0908808a 2024-05-03 12:32:43 +00:00 Compare
fyrchik reviewed 2024-05-06 05:27:30 +00:00
fyrchik left a comment
Owner
Copy link

We have recently added an extensive test suite for get-range #1078
Could you extend it for erasure-coded objects?

We have recently added an extensive test suite for get-range #1078 Could you extend it for erasure-coded objects?
👍 1
acid-ant force-pushed feature/ec-range-hash from af0908808a to 556defe0bf 2024-05-07 09:45:49 +00:00 Compare
acid-ant force-pushed feature/ec-range-hash from 556defe0bf to e34426055e 2024-05-07 09:46:32 +00:00 Compare
fyrchik approved these changes 2024-05-07 10:00:21 +00:00
acid-ant commented 2024-05-07 10:14:46 +00:00
Author
Member
Copy link

Cherry-picked changes from 0.38 with tests for range. Added test for range request for EC object.

Cherry-picked changes from 0.38 with tests for range. Added test for `range` request for EC object.
acid-ant force-pushed feature/ec-range-hash from 3ee0eb9ff1 to c0cdba21e4 2024-05-07 11:33:31 +00:00 Compare
fyrchik approved these changes 2024-05-07 11:37:46 +00:00
docs/images/authentication/impersonate.puml Outdated
@ -13,3 +13,3 @@
@enduml
@enduml
fyrchik commented 2024-05-07 11:37:44 +00:00
Owner
Copy link

Should be fixed in master, could you rebase?

Should be fixed in master, could you rebase?
acid-ant commented 2024-05-07 11:48:56 +00:00
Author
Member
Copy link

Done.

Done.
acid-ant force-pushed feature/ec-range-hash from c0cdba21e4 to fe2c1c926f 2024-05-07 11:47:35 +00:00 Compare
fyrchik merged commit fe2c1c926f into master 2024-05-07 12:32:30 +00:00
fyrchik referenced this pull request from a commit 2024-05-07 12:32:33 +00:00
[#1112] Fix issue from `gofumpt`
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1112
No description provided.
Delete branch "acid-ant/frostfs-node:feature/ec-range-hash"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?