TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 95 Pull Requests 7 Actions Releases Activity

cli: Improve APE rule parsing #1124

Merged
fyrchik merged 2 commits from aarifullin/frostfs-node:feat/improve_ape_parsing into master 2024-05-14 10:03:13 +00:00
Conversation 1 Commits 2 Files Changed 12
aarifullin commented 2024-05-07 17:59:17 +00:00
Collaborator

Picked commit from support branch: #1108

ape: Update policy-engine version for listing by iteration

  • Update go.mod with a new version of policy-engine pacakge.
  • Adapt SwitchRPCGuardedActor to ContractStorage interface.
  • Fix frostfs-adm util.

Updating policy-engine (depends on previos commit):

  • Make APE rule parser to read condition's kind in unambiguous using lexemes
    ResourceCondition, RequestCondition instead confusing Object.Request, Object.Resource.
  • Fix unit-tests.
Picked commit from support branch: https://git.frostfs.info/TrueCloudLab/frostfs-node/pulls/1108 ape: Update policy-engine version for listing by iteration * Update go.mod with a new version of policy-engine pacakge. * Adapt SwitchRPCGuardedActor to ContractStorage interface. * Fix `frostfs-adm` util. Updating policy-engine (depends on previos commit): * Make APE rule parser to read condition's kind in unambiguous using lexemes `ResourceCondition`, `RequestCondition` instead confusing `Object.Request`, `Object.Resource`. * Fix unit-tests.
aarifullin added 1 commit 2024-05-07 17:59:19 +00:00
Vulncheck / Vulncheck (pull_request) Successful in 3m19s Details
DCO action / DCO (pull_request) Failing after 3m11s Details
Build / Build Components (1.21) (pull_request) Successful in 4m26s Details
Build / Build Components (1.22) (pull_request) Successful in 4m22s Details
Tests and linters / gopls check (pull_request) Successful in 4m51s Details
Tests and linters / Staticcheck (pull_request) Successful in 5m18s Details
Tests and linters / Lint (pull_request) Successful in 6m39s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 8m17s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m59s Details
Tests and linters / Tests with -race (pull_request) Successful in 9m59s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 10m15s Details
7161fad8cd [#XX] cli: Improve APE rule parsing 
* Make APE rule parser to read condition's kind in unambiguous using lexemes
 `ResourceCondition`, `RequestCondition` instead confusing `Object.Request`, `Object.Resource`.
* Fix unit-tests.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2024-05-07 17:59:26 +00:00
aarifullin requested review from storage-core-developers 2024-05-07 17:59:27 +00:00
acid-ant approved these changes 2024-05-08 06:26:02 +00:00
acid-ant commented 2024-05-08 06:26:22 +00:00
Collaborator

Please fix commit message.

Please fix commit message.
aarifullin force-pushed feat/improve_ape_parsing from 7161fad8cd to cb95fb6020 2024-05-08 07:18:26 +00:00 Compare
aarifullin requested review from acid-ant 2024-05-08 07:19:03 +00:00
acid-ant approved these changes 2024-05-13 06:54:00 +00:00
aarifullin changed title from cli: Improve APE rule parsing to WIP: cli: Improve APE rule parsing 2024-05-13 14:29:42 +00:00
aarifullin added the
blocked
 label 2024-05-13 15:20:55 +00:00
aarifullin force-pushed feat/improve_ape_parsing from cb95fb6020 to 952d13cd2b 2024-05-14 09:24:35 +00:00 Compare
aarifullin changed title from WIP: cli: Improve APE rule parsing to cli: Improve APE rule parsing 2024-05-14 09:26:02 +00:00
aarifullin requested review from acid-ant 2024-05-14 09:26:28 +00:00
fyrchik approved these changes 2024-05-14 10:03:04 +00:00
fyrchik merged commit 952d13cd2b into master 2024-05-14 10:03:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1124
There is no content yet.
Delete Branch "aarifullin/frostfs-node:feat/improve_ape_parsing"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?