TrueCloudLab
/
frostfs-node
17
1
Fork 22
Code Issues 90 Pull Requests 8 Actions Projects Releases Activity

adm: Fix dump-config output #1139

Closed
elebedeva wants to merge 1 commits from elebedeva:fix/ffs-adm-output into master
pull from: elebedeva:fix/ffs-adm-output
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files Changed 2
elebedeva commented 2024-05-16 18:13:30 +00:00
Collaborator

Added preferable type to params in frostfs-adm morph dump-config output.

service@ekaterinalebedeva-node1[alone_datacenter]:~$ frostfs-adm morph dump-config  -r http://localhost:40332
EigenTrustAlpha:             0.1 (string)
EigenTrustIterations:        4 (int)
EpochDuration:               75 (int)
InnerRingCandidateFee:       10000000000 (int)
MaintenanceModeAllowed:      true (bool)
AuditFee:                    0 (int)
BasicIncomeRate:             0 (int)
ContainerFee:                0 (int)
WithdrawFee:                 100000000 (int)
ContainerAliasFee:           0 (int)
HomomorphicHashingDisabled:  true (bool)
MaxObjectSize:               5242880 (int)

Also, in the original issue there is a problem with MaxECParityCount and MaxECDataCount parameters type. However, I wasn't able to reproduce it:
Screenshot from 2024-05-16 20-22-18-1

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Added preferable type to params in `frostfs-adm morph dump-config` output. ``` service@ekaterinalebedeva-node1[alone_datacenter]:~$ frostfs-adm morph dump-config -r http://localhost:40332 EigenTrustAlpha: 0.1 (string) EigenTrustIterations: 4 (int) EpochDuration: 75 (int) InnerRingCandidateFee: 10000000000 (int) MaintenanceModeAllowed: true (bool) AuditFee: 0 (int) BasicIncomeRate: 0 (int) ContainerFee: 0 (int) WithdrawFee: 100000000 (int) ContainerAliasFee: 0 (int) HomomorphicHashingDisabled: true (bool) MaxObjectSize: 5242880 (int) ``` Also, in the original issue there is a problem with `MaxECParityCount` and `MaxECDataCount` parameters type. However, I wasn't able to reproduce it: ![Screenshot from 2024-05-16 20-22-18-1](/attachments/54c4e180-778c-4de9-8db4-7d1a538adc26) Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
Screenshot from 2024-05-16 20-22-18-1.png
48 KiB
elebedeva added 1 commit 2024-05-16 18:13:35 +00:00
DCO action / DCO (pull_request) Failing after 1m26s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m8s Details
Build / Build Components (1.22) (pull_request) Successful in 3m56s Details
Build / Build Components (1.21) (pull_request) Successful in 4m2s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m27s Details
Tests and linters / Staticcheck (pull_request) Successful in 4m44s Details
Tests and linters / gopls check (pull_request) Successful in 5m2s Details
Tests and linters / Lint (pull_request) Successful in 5m54s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 8m55s Details
Tests and linters / Tests with -race (pull_request) Successful in 8m52s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 9m6s Details
6f0e52238c [OBJECT-8900] adm: fix dump-config output 
Added preferable type to params in `frostfs-adm morph dump-config`
output.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
fyrchik commented 2024-05-16 19:16:00 +00:00
Owner

Please, use #1139 as the commit message prefix, OBJECT-8900 is not a public link.

Please, use #1139 as the commit message prefix, `OBJECT-8900` is not a public link.
👍 1
elebedeva force-pushed fix/ffs-adm-output from 6f0e52238c to c255d3ea12 2024-05-17 10:30:34 +00:00 Compare
elebedeva changed title from WIP: adm: Fix dump-config output to adm: Fix dump-config output 2024-05-17 11:01:45 +00:00
elebedeva requested review from storage-core-committers 2024-05-17 11:01:56 +00:00
elebedeva requested review from storage-core-developers 2024-05-17 11:01:56 +00:00
dstepanov-yadro approved these changes 2024-05-17 11:16:59 +00:00
aarifullin approved these changes 2024-05-17 12:27:14 +00:00
fyrchik reviewed 2024-05-17 13:15:14 +00:00
cmd/frostfs-adm/internal/modules/morph/config/config.go
@ -62,3 +62,3 @@
netmap.EpochDurationConfig, netmap.IrCandidateFeeConfig,
netmap.MaxObjectSizeConfig, netmap.WithdrawFeeConfig,
netmap.MaxECDataCountConfig, netmap.MaxECParityCountConfig:
netmap.MaxECDataCountConfig, netmap.MaxECParityCountConfig,
fyrchik commented 2024-05-17 13:15:14 +00:00
Owner

The task was mostly about EC fields.
The others were intentionally deleted, as they are unused and thus are output in hex as the default format.

The task was mostly about EC fields. The others were intentionally deleted, as they are unused and thus are output in hex as the default format.
elebedeva commented 2024-05-21 11:09:13 +00:00
Poster
Collaborator

Then there is no problem to fix, closing PR.

Then there is no problem to fix, closing PR.
fyrchik marked this conversation as resolved
elebedeva closed this pull request 2024-05-21 11:09:17 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 2m48s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m3s
Details
Build / Build Components (1.22) (pull_request) Successful in 4m1s
Details
Build / Build Components (1.21) (pull_request) Successful in 4m6s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m35s
Details
Tests and linters / gopls check (pull_request) Successful in 4m48s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m35s
Details
Tests and linters / Lint (pull_request) Successful in 6m24s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 8m54s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m0s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 9m13s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
aarifullin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1139
There is no content yet.
Delete Branch "elebedeva:fix/ffs-adm-output"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?