Fix `IsUserObject` for ec-splitted objects #1141

Merged

fyrchik merged 3 commits from aarifullin/frostfs-node:feat/ec_userobj into master

2024-05-20 12:45:42 +00:00

aarifullin commented

2024-05-20 10:22:28 +00:00

Collaborator

go.mod: Update frostfs-sdk-go and frostfs-api-go/v2. Also, unit-tests are fixed;
Fix putUniqueIndexItem, because GetECHeader is not correct way to determine if an object's got EC-header: ECHeader must be used for that;
metabase: Fix IsUserObject method

* go.mod: Update frostfs-sdk-go and frostfs-api-go/v2. Also, unit-tests are fixed; * Fix `putUniqueIndexItem`, because `GetECHeader` is not correct way to determine if an object's got EC-header: `ECHeader` must be used for that; * metabase: Fix `IsUserObject` method

aarifullin added 3 commits 2024-05-20 10:22:40 +00:00

4c581ba62d [#XX] go.mod: Update frostfs-sdk-go and frostfs-api-go/v2

* Also fix unit-test.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

67efe0f63c [#XX] metabase: Fix `putUniqueIndexItem`

* `GetECHeader` is not correct way to determine if an object's got
  EC-header: `ECHeader` must be used for that.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

Build / Build Components (1.21) (pull_request) Successful in 2m33s Details

DCO action / DCO (pull_request) Failing after 3m2s Details

Build / Build Components (1.22) (pull_request) Successful in 4m15s Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 4m33s Details

Vulncheck / Vulncheck (pull_request) Successful in 4m29s Details

Tests and linters / gopls check (pull_request) Successful in 9m3s Details

Tests and linters / Lint (pull_request) Successful in 10m2s Details

Tests and linters / Staticcheck (pull_request) Successful in 9m48s Details

Tests and linters / Tests (1.22) (pull_request) Failing after 14m58s Details

Tests and linters / Tests (1.21) (pull_request) Failing after 15m5s Details

Tests and linters / Tests with -race (pull_request) Failing after 16m31s Details

aba5d84bb1 [#XX] metabase: Fix `IsUserObject` method

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

aarifullin force-pushed feat/ec_userobj from aba5d84bb1 to 40b04c00ef

2024-05-20 10:24:55 +00:00

Compare

aarifullin requested review from storage-core-committers 2024-05-20 10:24:59 +00:00

aarifullin requested review from storage-core-developers 2024-05-20 10:25:14 +00:00

fyrchik approved these changes 2024-05-20 10:37:07 +00:00

fyrchik commented

2024-05-20 10:46:55 +00:00

Owner

have you checked user metrics on dev-env?

have you checked `user` metrics on dev-env?

aarifullin commented

2024-05-20 10:48:06 +00:00

Poster

Collaborator

have you checked user metrics on dev-env?

I haven't. But I think you're right - I should check it locally

> have you checked `user` metrics on dev-env? I haven't. But I think you're right - I should check it locally

acid-ant approved these changes 2024-05-20 11:03:03 +00:00

aarifullin commented

2024-05-20 11:49:34 +00:00

Poster

Collaborator

have you checked user metrics on dev-env?

I tried to check this with prometheus UI and find metric values with frostfs_node_engine_objects_total{type="user"}

REP 1 policy, object is small. It's counted like +1
REP 1 policy, object is big (to Split it). It's counted like +1
EC 3.1 CBF 1 policy. object is small. It's counted like +1
EC 3.1 CBF 1 policy. object is big (to Split it). It's counted like +1

I believe that's correct

> have you checked `user` metrics on dev-env? I tried to check this with prometheus UI and find metric values with `frostfs_node_engine_objects_total{type="user"}` 1. `REP 1` policy, object is small. It's counted like +1 ![REP_1_SMALL](/attachments/ee17fdcd-712e-4ef8-9be5-721ed272591c) 2. `REP 1` policy, object is big (to `Split` it). It's counted like +1 ![REP_1_SPLIT_BIG](/attachments/c87ea5ad-24d3-407a-90c9-f09db96a8966) 3. `EC 3.1 CBF 1` policy. object is small. It's counted like +1 ![EC_SMALL](/attachments/596f7fbf-a0f0-41a4-bf00-91f08a725a6b) 3. `EC 3.1 CBF 1` policy. object is big (to `Split` it). It's counted like +1 ![EC_SPLIT](/attachments/a3d4e9a5-868e-425f-a483-7334c6f9be0e) I believe that's correct

REP_1_SMALL.PNG

20 KiB

REP_1_SPLIT_BIG.PNG

25 KiB

EC_SMALL.PNG

40 KiB

EC_SPLIT.PNG

53 KiB

🚀 1