TrueCloudLab
/
frostfs-node
17
1
Fork 22
Code Issues 90 Pull Requests 8 Actions Projects Releases Activity

metabase: Fix EC storage schema #1160

Merged
dstepanov-yadro merged 1 commits from dstepanov-yadro/frostfs-node:fix/ec_chunks_metabase_schema into master 2024-06-04 14:35:27 +00:00
Conversation 3 Commits 1 Files Changed 5
dstepanov-yadro commented 2024-06-04 10:32:24 +00:00
Collaborator

Do not store EC info twice.

Relates #1158

Do not store EC info twice. Relates #1158
dstepanov-yadro added 1 commit 2024-06-04 10:32:26 +00:00
DCO action / DCO (pull_request) Successful in 1m46s Details
Vulncheck / Vulncheck (pull_request) Successful in 3m19s Details
Tests and linters / gopls check (pull_request) Successful in 8m13s Details
Tests and linters / Staticcheck (pull_request) Successful in 8m21s Details
Build / Build Components (1.21) (pull_request) Successful in 8m25s Details
Build / Build Components (1.22) (pull_request) Successful in 8m20s Details
Tests and linters / Lint (pull_request) Successful in 9m56s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 12m58s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 13m25s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m42s Details
Tests and linters / Tests with -race (pull_request) Successful in 14m27s Details
f6703bf9b3 [#1158] metabase: Fix EC storae schema 
Do not store EC info twice.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/ec_chunks_metabase_schema from f6703bf9b3 to 5d2241d01a 2024-06-04 10:33:10 +00:00 Compare
dstepanov-yadro reviewed 2024-06-04 10:38:25 +00:00
pkg/local_object_storage/metabase/delete.go Outdated
@ -473,46 +473,6 @@ func delUniqueIndexes(tx *bbolt.Tx, obj *objectSDK.Object, isParent bool) error
name: rootBucketName(cnr, bucketName),
key: objKey,
})
if obj.ECHeader() != nil {
dstepanov-yadro commented 2024-06-04 10:38:24 +00:00
Poster
Collaborator

EC info will be deleted here:

5d2241d01a/pkg/local_object_storage/metabase/delete.go (L335)

5d2241d01a/pkg/local_object_storage/metabase/put.go (L341)

EC info will be deleted here: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/5d2241d01abc251f8c1e08e538dc80ce2c80ac49/pkg/local_object_storage/metabase/delete.go#L335 https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/5d2241d01abc251f8c1e08e538dc80ce2c80ac49/pkg/local_object_storage/metabase/put.go#L341
dstepanov-yadro reviewed 2024-06-04 10:41:00 +00:00
pkg/local_object_storage/metabase/put.go Outdated
@ -259,9 +258,6 @@ func putUniqueIndexes(
isObjKeySet := true
if ecHead := obj.ECHeader(); ecHead != nil {
if err = putECInfo(tx, cnr, objKey, ecHead); err != nil {
dstepanov-yadro commented 2024-06-04 10:41:00 +00:00
Poster
Collaborator

EC will be inserted here:

5d2241d01a/pkg/local_object_storage/metabase/put.go (L171)

5d2241d01a/pkg/local_object_storage/metabase/put.go (L341)

EC will be inserted here: https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/5d2241d01abc251f8c1e08e538dc80ce2c80ac49/pkg/local_object_storage/metabase/put.go#L171 https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/5d2241d01abc251f8c1e08e538dc80ce2c80ac49/pkg/local_object_storage/metabase/put.go#L341
dstepanov-yadro requested review from storage-core-committers 2024-06-04 10:42:28 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-06-04 10:42:34 +00:00
dstepanov-yadro changed title from WIP: metabase: Fix EC storage schema to metabase: Fix EC storage schema 2024-06-04 10:42:45 +00:00
fyrchik commented 2024-06-04 11:02:47 +00:00
Owner

Have you run sanity tests?

Have you run sanity tests?
fyrchik approved these changes 2024-06-04 11:02:53 +00:00
dstepanov-yadro commented 2024-06-04 11:03:32 +00:00
Poster
Collaborator

Have you run sanity tests?

Nope, only unit tests.

> Have you run sanity tests? Nope, only unit tests.
acid-ant approved these changes 2024-06-04 12:45:13 +00:00
dstepanov-yadro force-pushed fix/ec_chunks_metabase_schema from 5d2241d01a to cc2449beaf 2024-06-04 14:25:01 +00:00 Compare
dstepanov-yadro commented 2024-06-04 14:32:34 +00:00
Poster
Collaborator

Have you run sanity tests?

Done

> Have you run sanity tests? Done
dstepanov-yadro merged commit cc2449beaf into master 2024-06-04 14:35:27 +00:00
dstepanov-yadro deleted branch fix/ec_chunks_metabase_schema 2024-06-04 14:35:28 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1160
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:fix/ec_chunks_metabase_schema"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?