ape: Return not found when removing local overrides #1162

acid-ant · 2024-06-04T15:29:10Z

acid-ant commented

2024-06-04 15:29:10 +00:00

Close #1156

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #1156 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

acid-ant force-pushed bugfix/1156-remove-policy-unknown from db04c42f6d to f7d6455ed0

2024-06-04 15:30:33 +00:00

Compare

acid-ant changed title from ~~WIP: ape: Return `not found` when removing local overrides~~ to ape: Return `not found` when removing local overrides

2024-06-04 15:30:52 +00:00

acid-ant requested review from storage-core-committers 2024-06-04 15:31:05 +00:00

acid-ant requested review from storage-core-developers 2024-06-04 15:31:13 +00:00

fyrchik approved these changes 2024-06-04 18:50:42 +00:00

fyrchik commented

2024-06-05 09:50:43 +00:00

Please, look at tests.

acid-ant commented

2024-06-05 10:16:36 +00:00

Please, look at tests.

Passed.

> Please, look at tests. Passed.

dkirillov reviewed 2024-06-05 10:55:49 +00:00

pkg/services/control/server/policy_engine.go Outdated

					
				@ -179,2 +177,2 @@

							return nil, status.Error(code, err.Error())

						}

					if err = s.localOverrideStorage.LocalStorage().RemoveOverride(apechain.Ingress, target, req.GetBody().GetChainId()); err != nil {

						return nil, status.Error(getCodeByLocalStorageErr(err), err.Error())

dkirillov commented

2024-06-05 10:55:49 +00:00

Error still be internal rather than not found because in getCodeByLocalStorageErr we dont handle engine.ErrResourceNotFound

Error still be `internal` rather than `not found` because in [getCodeByLocalStorageErr](https://git.frostfs.info/acid-ant/frostfs-node/src/commit/f7d6455ed024285cabfb4bafe48b58bba27c62ae/pkg/services/control/server/policy_engine.go#L245) we dont handle `engine.ErrResourceNotFound`

acid-ant commented

2024-06-05 12:58:22 +00:00

Oh, missed that. Fixed.