Improve object nodes performance #1169

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/improve_object_nodes_perf into master 2024-06-11 08:04:28 +00:00

References #1164

Do complex EC object parts flatten concurrently.

Before:
image

After:
image

References #1164 Do complex EC object parts flatten concurrently. Before: ![image](/attachments/30c32805-9b27-4285-a54e-f64e42939bcf) After: ![image](/attachments/8bb2920d-35b4-4980-b6d2-e8dcc98128b8)
230 KiB
225 KiB
dstepanov-yadro force-pushed feat/improve_object_nodes_perf from efae72af40 to 309f93fcb8 2024-06-07 13:22:11 +00:00 Compare
dstepanov-yadro requested review from storage-core-developers 2024-06-07 14:43:04 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-06-07 14:43:08 +00:00
acid-ant approved these changes 2024-06-10 13:56:00 +00:00
fyrchik approved these changes 2024-06-10 15:03:33 +00:00
@ -180,30 +183,66 @@ func getCompexObjectMembers(cmd *cobra.Command, cnrID cid.ID, objID oid.ID, cli
func flattenComplexMembersIfECContainer(cmd *cobra.Command, cnrID cid.ID, members []oid.ID, prmHead internalclient.HeadObjectPrm) []phyObject {
result := make([]phyObject, 0, len(members))
var resultGuard sync.Mutex
Owner

What about declaring it close to the loop it is actually used?

What about declaring it close to the loop it is actually used?
Owner

What about declaring it close to the loop it is actually used?

What about declaring it close to the loop it is actually used?
Author
Member

I prefer to declare mutex close to the variable it protects.

I prefer to declare mutex close to the variable it protects.
dstepanov-yadro force-pushed feat/improve_object_nodes_perf from 309f93fcb8 to 069c1559cc 2024-06-11 05:46:20 +00:00 Compare
dstepanov-yadro merged commit 069c1559cc into master 2024-06-11 08:04:28 +00:00
dstepanov-yadro deleted branch feat/improve_object_nodes_perf 2024-06-11 08:04:33 +00:00
fyrchik added this to the v0.41.0 milestone 2024-06-14 07:00:44 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1169
No description provided.