TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 90 Pull requests 3 Projects Releases 1 Activity Actions

Improve object nodes performance #1169

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/improve_object_nodes_perf into master 2024-06-11 08:04:28 +00:00
Conversation 0 Commits 1 Files changed 1 +59 -20
dstepanov-yadro commented 2024-06-07 13:20:51 +00:00
Member
Copy link

References #1164

Do complex EC object parts flatten concurrently.

Before:
image

After:
image

References #1164 Do complex EC object parts flatten concurrently. Before: ![image](/attachments/30c32805-9b27-4285-a54e-f64e42939bcf) After: ![image](/attachments/8bb2920d-35b4-4980-b6d2-e8dcc98128b8)
image.png
230 KiB
image.png
225 KiB
dstepanov-yadro force-pushed feat/improve_object_nodes_perf from efae72af40 to 309f93fcb8 2024-06-07 13:22:11 +00:00 Compare
dstepanov-yadro requested review from storage-core-developers 2024-06-07 14:43:04 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-06-07 14:43:08 +00:00
acid-ant approved these changes 2024-06-10 13:56:00 +00:00
fyrchik approved these changes 2024-06-10 15:03:33 +00:00
cmd/frostfs-cli/modules/object/nodes.go Outdated
@ -180,30 +183,66 @@ func getCompexObjectMembers(cmd *cobra.Command, cnrID cid.ID, objID oid.ID, cli
func flattenComplexMembersIfECContainer(cmd *cobra.Command, cnrID cid.ID, members []oid.ID, prmHead internalclient.HeadObjectPrm) []phyObject {
result := make([]phyObject, 0, len(members))
var resultGuard sync.Mutex
fyrchik commented 2024-06-10 15:03:05 +00:00
Owner
Copy link

What about declaring it close to the loop it is actually used?

What about declaring it close to the loop it is actually used?
fyrchik commented 2024-06-10 15:03:07 +00:00
Owner
Copy link

What about declaring it close to the loop it is actually used?

What about declaring it close to the loop it is actually used?
dstepanov-yadro commented 2024-06-11 05:49:54 +00:00
Author
Member
Copy link

I prefer to declare mutex close to the variable it protects.

I prefer to declare mutex close to the variable it protects.
dstepanov-yadro force-pushed feat/improve_object_nodes_perf from 309f93fcb8 to 069c1559cc 2024-06-11 05:46:20 +00:00 Compare
dstepanov-yadro merged commit 069c1559cc into master 2024-06-11 08:04:28 +00:00
dstepanov-yadro deleted branch feat/improve_object_nodes_perf 2024-06-11 08:04:33 +00:00
fyrchik added this to the v0.41.0 milestone 2024-06-14 07:00:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
v0.41.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1169
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/improve_object_nodes_perf"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?