TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 103 Pull requests 4 Projects Releases 2 Activity Actions

shard: Use mode from config on reload #1182

Merged
fyrchik merged 1 commit from acid-ant/frostfs-node:bugfix/1173-use-mode-from-cfg-on-reload into master 2024-06-20 11:29:19 +00:00
Conversation 1 Commits 1 Files changed 2 +1 -4
acid-ant commented 2024-06-18 08:15:41 +00:00
Member
Copy link

Close #1173

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Close #1173 Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant commented 2024-06-18 09:12:43 +00:00
Author
Member
Copy link

Updated log message.

Updated log message.
acid-ant force-pushed bugfix/1173-use-mode-from-cfg-on-reload from 8c1657921d to 45ac7201ed 2024-06-18 09:14:58 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-06-18 09:15:08 +00:00
acid-ant requested review from storage-core-developers 2024-06-18 09:15:11 +00:00
acid-ant force-pushed bugfix/1173-use-mode-from-cfg-on-reload from 45ac7201ed to 3adb462b1c 2024-06-18 09:15:49 +00:00 Compare
dstepanov-yadro approved these changes 2024-06-18 09:42:27 +00:00
achuprov approved these changes 2024-06-18 09:49:03 +00:00
aarifullin approved these changes 2024-06-18 11:35:45 +00:00
fyrchik reviewed 2024-06-18 12:02:31 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -421,3 +421,2 @@
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
return s.setMode(mode.ReadWrite)
s.log.Info(logs.ShardTryingToSetModeFromConfig)
fyrchik commented 2024-06-18 12:02:30 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
fyrchik commented 2024-06-18 12:03:19 +00:00
Owner
Copy link

О in Gitea stays for "Отзывчивость"

О in Gitea stays for "Отзывчивость"
😆 1
acid-ant commented 2024-06-19 14:04:41 +00:00
Author
Member
Copy link

It's already done here, looks redundant.

It's already done [here](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/75eedf71f31c8d0d68500779954e708fa884c3ee/pkg/local_object_storage/shard/mode.go#L28), looks redundant.
fyrchik commented 2024-06-19 17:23:44 +00:00
Owner
Copy link

How about removing this line then? Seems redundant.

How about removing this line then? Seems redundant.
acid-ant commented 2024-06-20 05:56:17 +00:00
Author
Member
Copy link

Agree, updated.

Agree, updated.
fyrchik reviewed 2024-06-18 12:02:33 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -421,3 +421,2 @@
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
return s.setMode(mode.ReadWrite)
s.log.Info(logs.ShardTryingToSetModeFromConfig)
fyrchik commented 2024-06-18 12:02:33 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
fyrchik reviewed 2024-06-18 12:02:39 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -421,3 +421,2 @@
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
return s.setMode(mode.ReadWrite)
s.log.Info(logs.ShardTryingToSetModeFromConfig)
fyrchik commented 2024-06-18 12:02:39 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
fyrchik commented 2024-06-18 12:02:40 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
fyrchik commented 2024-06-18 12:02:40 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
fyrchik reviewed 2024-06-18 12:02:41 +00:00
pkg/local_object_storage/shard/control.go Outdated
@ -421,3 +421,2 @@
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
return s.setMode(mode.ReadWrite)
s.log.Info(logs.ShardTryingToSetModeFromConfig)
fyrchik commented 2024-06-18 12:02:41 +00:00
Owner
Copy link

Add zap.Stringer("mode", mode) ?

Add `zap.Stringer("mode", mode)` ?
acid-ant force-pushed bugfix/1173-use-mode-from-cfg-on-reload from 3adb462b1c to 5546ee1027 2024-06-20 05:56:10 +00:00 Compare
elebedeva approved these changes 2024-06-20 07:30:28 +00:00
fyrchik merged commit 9ac74efc41 into master 2024-06-20 11:29:19 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
achuprov
aarifullin
elebedeva
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1182
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/1173-use-mode-from-cfg-on-reload"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?