TrueCloudLab/frostfs-node
18
1
Fork 27
Code Issues 92 Pull requests 4 Projects Releases 1 Activity Actions

[SUPPORT] shard: Use mode from config on reload #1183

Closed
acid-ant wants to merge 1 commit from acid-ant/frostfs-node:bugfix/1173-use-mode-from-cfg-on-reload-support into support/v0.38
pull from: acid-ant/frostfs-node:bugfix/1173-use-mode-from-cfg-on-reload-support
merge into: TrueCloudLab:support/v0.38
Conversation 0 Commits 1 Files changed 1 +1 -1
acid-ant commented 2024-06-18 08:23:41 +00:00
Member
Copy link

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2024-06-18 08:24:18 +00:00
[#1173] shard: Use mode from config on reload
Some checks failed
Build / Build Components (1.20) (pull_request) Failing after 21m13s
Details
Build / Build Components (1.21) (pull_request) Failing after 21m8s
Details
DCO action / DCO (pull_request) Failing after 21m3s
Details
Vulncheck / Vulncheck (pull_request) Failing after 20m25s
Details
Tests and linters / gopls check (pull_request) Successful in 6m44s
Details
Tests and linters / Staticcheck (pull_request) Successful in 7m7s
Details
Tests and linters / Lint (pull_request) Successful in 7m59s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 9m31s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m52s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m53s
Details
cf581a2384 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
fyrchik requested changes 2024-06-18 08:42:30 +00:00
pkg/local_object_storage/shard/control.go
@ -360,7 +360,7 @@ func (s *Shard) Reload(ctx context.Context, opts ...Option) error {
}
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
fyrchik commented 2024-06-18 08:42:05 +00:00
Owner
Copy link

The log message does no longer correspond to the action.

The log message does no longer correspond to the action.
pkg/local_object_storage/shard/control.go
@ -361,3 +361,3 @@
s.log.Info(logs.ShardTryingToRestoreReadwriteMode)
return s.setMode(mode.ReadWrite)
return s.setMode(c.info.Mode)
fyrchik commented 2024-06-18 08:42:27 +00:00
Owner
Copy link

This is a change of behaviour, should not be in the support branch.

This is a change of behaviour, should not be in the support branch.
acid-ant closed this pull request 2024-06-18 09:06:58 +00:00
Some checks failed
Build / Build Components (1.20) (pull_request) Failing after 21m13s
Details
Build / Build Components (1.21) (pull_request) Failing after 21m8s
Details
DCO action / DCO (pull_request) Failing after 21m3s
Details
Vulncheck / Vulncheck (pull_request) Failing after 20m25s
Details
Tests and linters / gopls check (pull_request) Successful in 6m44s
Details
Tests and linters / Staticcheck (pull_request) Successful in 7m7s
Details
Tests and linters / Lint (pull_request) Successful in 7m59s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 9m31s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 9m52s
Details
Tests and linters / Tests with -race (pull_request) Successful in 9m53s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1183
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/1173-use-mode-from-cfg-on-reload-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?