TrueCloudLab/frostfs-node

Cache metrics #1199

Merged

fyrchik merged 2 commits from dstepanov-yadro/frostfs-node:feat/cache_metrics into master

2024-06-25 08:52:39 +00:00

dstepanov-yadro commented

2024-06-25 07:27:56 +00:00

Member

Move metrics to internal. Don't think someone wants to import our metrics.
Add common cache metrics.

Grafana dashboards example:

Closes #451

1. Move metrics to internal. Don't think someone wants to import our metrics. 2. Add common cache metrics. Grafana dashboards example: ![image](/attachments/c51f1590-bc8b-469c-952d-a1726ab07fd1) ![image](/attachments/07f7175f-cb33-48dc-96c4-af3bb173c622) Closes #451

100 KiB

84 KiB

dstepanov-yadro added 1 commit 2024-06-25 07:28:05 +00:00

[#451 ] metrics: Move to internal 9c64c6a2c4

`metrics` don't look like something others want to import.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>

fyrchik requested changes 2024-06-25 07:39:45 +00:00

internal/metrics/cache.go Outdated

					
				@ -0,0 +12,4 @@

					Namespace: namespace,

					Subsystem: commonCacheSubsystem,

					Name:      "request_duration_seconds",

					Help:      "Accumulated Blobstore request process duration",

fyrchik commented

2024-06-25 07:39:22 +00:00

Owner

Is the message right? (same about name)

Is the message right? (same about name)

dstepanov-yadro commented

2024-06-25 07:44:18 +00:00

Author

Member

fixed. name is ok: final metric name is frostfs_node_common_cache_request_duration_seconds

fixed. name is ok: final metric name is `frostfs_node_common_cache_request_duration_seconds`

dstepanov-yadro force-pushed feat/cache_metrics from a5c758b9f3 to 9f36dd6f5e

2024-06-25 07:43:06 +00:00

Compare

dstepanov-yadro requested review from storage-core-committers 2024-06-25 08:09:30 +00:00

dstepanov-yadro requested review from storage-core-developers 2024-06-25 08:09:32 +00:00

acid-ant approved these changes 2024-06-25 08:16:26 +00:00

aarifullin approved these changes 2024-06-25 08:22:12 +00:00

aarifullin left a comment

Member

Awesome

Awesome

fyrchik merged commit df894fbac7 into master

2024-06-25 08:52:39 +00:00

Sign in to join this conversation.

No reviewers

No labels

good first issue

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1199

No description provided.