Add info metric #1202

Merged
fyrchik merged 2 commits from achuprov/frostfs-node:feat/info_metric into master 2024-06-27 12:02:58 +00:00
Member

Close: #1154

achuprov@NB-4053:~/Documents/work/neo-go$ curl s01.frostfs.devenv:9090 | grep app_info
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP app_info General information about the application.
# TYPE app_info gauge
app_info{version="v0.40.0-7-g3f196115-dirty"} 0
100 95243    0 95243    0     0  37.7M      0 --:--:-- --:--:-- --:--:-- 45.4M

achuprov@NB-4053:~/Documents/work/neo-go$ curl ir01.frostfs.devenv:9090 | grep app_info
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP app_info General information about the application.
# TYPE app_info gauge
app_info{version="v0.40.0-7-g3f196115-dirty"} 0
100 18117    0 18117    0     0  7825k      0 --:--:-- --:--:-- --:--:-- 8846k

Close: #1154 ``` achuprov@NB-4053:~/Documents/work/neo-go$ curl s01.frostfs.devenv:9090 | grep app_info % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0# HELP app_info General information about the application. # TYPE app_info gauge app_info{version="v0.40.0-7-g3f196115-dirty"} 0 100 95243 0 95243 0 0 37.7M 0 --:--:-- --:--:-- --:--:-- 45.4M ``` ``` achuprov@NB-4053:~/Documents/work/neo-go$ curl ir01.frostfs.devenv:9090 | grep app_info % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0# HELP app_info General information about the application. # TYPE app_info gauge app_info{version="v0.40.0-7-g3f196115-dirty"} 0 100 18117 0 18117 0 0 7825k 0 --:--:-- --:--:-- --:--:-- 8846k ```
fyrchik requested changes 2024-06-25 15:19:34 +00:00
misc/build.go Outdated
@ -21,1 +21,4 @@
}
func VersionInfo(component string) string {
return fmt.Sprintf("%s-%s",
Owner

Honestly, I feel like component is not needed here: we already now the endpoint we are using.

Honestly, I feel like component is not needed here: we already now the endpoint we are using.
achuprov force-pushed feat/info_metric from 3f3c7949c5 to 1941909a3b 2024-06-26 08:57:10 +00:00 Compare
achuprov force-pushed feat/info_metric from 1941909a3b to 9c140b98cc 2024-06-26 09:02:47 +00:00 Compare
achuprov force-pushed feat/info_metric from 9c140b98cc to e2ff7df914 2024-06-26 10:28:57 +00:00 Compare
achuprov changed title from WIP: Add info metric to Add info metric 2024-06-26 10:30:25 +00:00
achuprov requested review from storage-core-committers 2024-06-26 10:30:34 +00:00
achuprov requested review from storage-core-developers 2024-06-26 10:30:54 +00:00
acid-ant reviewed 2024-06-26 11:15:04 +00:00
@ -46,6 +48,7 @@ func NewInnerRingMetrics() *InnerRingServiceMetrics {
health: health,
eventDuration: eventDuration,
morphCacheMetrics: newMorphCacheMetrics(innerRingNamespace),
appInfo: NewApplicationInfo(misc.VersionInfo()),
Member

Why we can't use misc.Version here?

Why we can't use `misc.Version` here?
acid-ant marked this conversation as resolved
achuprov force-pushed feat/info_metric from e2ff7df914 to 8df4a58fda 2024-06-26 11:48:00 +00:00 Compare
fyrchik approved these changes 2024-06-26 12:01:20 +00:00
acid-ant approved these changes 2024-06-26 12:08:33 +00:00
dstepanov-yadro approved these changes 2024-06-26 12:30:52 +00:00
fyrchik merged commit 452faa3c89 into master 2024-06-27 12:02:57 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1202
No description provided.