Add info metric #1202

achuprov · 2024-06-25T15:16:04Z

achuprov commented

2024-06-25 15:16:04 +00:00

achuprov@NB-4053:~/Documents/work/neo-go$ curl s01.frostfs.devenv:9090 | grep app_info
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP app_info General information about the application.
# TYPE app_info gauge
app_info{version="v0.40.0-7-g3f196115-dirty"} 0
100 95243    0 95243    0     0  37.7M      0 --:--:-- --:--:-- --:--:-- 45.4M

achuprov@NB-4053:~/Documents/work/neo-go$ curl ir01.frostfs.devenv:9090 | grep app_info
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0# HELP app_info General information about the application.
# TYPE app_info gauge
app_info{version="v0.40.0-7-g3f196115-dirty"} 0
100 18117    0 18117    0     0  7825k      0 --:--:-- --:--:-- --:--:-- 8846k

Close: #1154 ``` achuprov@NB-4053:~/Documents/work/neo-go$ curl s01.frostfs.devenv:9090 | grep app_info % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0# HELP app_info General information about the application. # TYPE app_info gauge app_info{version="v0.40.0-7-g3f196115-dirty"} 0 100 95243 0 95243 0 0 37.7M 0 --:--:-- --:--:-- --:--:-- 45.4M ``` ``` achuprov@NB-4053:~/Documents/work/neo-go$ curl ir01.frostfs.devenv:9090 | grep app_info % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0# HELP app_info General information about the application. # TYPE app_info gauge app_info{version="v0.40.0-7-g3f196115-dirty"} 0 100 18117 0 18117 0 0 7825k 0 --:--:-- --:--:-- --:--:-- 8846k ```

fyrchik requested changes 2024-06-25 15:19:34 +00:00

misc/build.go Outdated

					
				@ -21,1 +21,4 @@

				}

				func VersionInfo(component string) string {

					return fmt.Sprintf("%s-%s",

fyrchik commented

2024-06-25 15:19:30 +00:00

Honestly, I feel like component is not needed here: we already now the endpoint we are using.

achuprov force-pushed feat/info_metric from 3f3c7949c5 to 1941909a3b

2024-06-26 08:57:10 +00:00

Compare

achuprov force-pushed feat/info_metric from 1941909a3b to 9c140b98cc

2024-06-26 09:02:47 +00:00

Compare

achuprov force-pushed feat/info_metric from 9c140b98cc to e2ff7df914

2024-06-26 10:28:57 +00:00

Compare

achuprov changed title from ~~WIP: Add info metric~~ to Add info metric

2024-06-26 10:30:25 +00:00

requested reviews from storage-core-committers, storage-core-developers

2024-06-26 10:30:54 +00:00

acid-ant reviewed 2024-06-26 11:15:04 +00:00

internal/metrics/innerring.go Outdated

					
				@ -46,6 +48,7 @@ func NewInnerRingMetrics() *InnerRingServiceMetrics {

						health:            health,

						eventDuration:     eventDuration,

						morphCacheMetrics: newMorphCacheMetrics(innerRingNamespace),

						appInfo:           NewApplicationInfo(misc.VersionInfo()),