TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 7 Actions Releases Activity

Do not allow to delete or lock EC chunks #1213

Merged
fyrchik merged 4 commits from dstepanov-yadro/frostfs-node:fix/lock_ec_chunk into master 2024-07-01 06:49:41 +00:00
Conversation 0 Commits 4 Files Changed 4
dstepanov-yadro commented 2024-06-28 14:50:58 +00:00
Collaborator

Do not allow to delete or lock EC chunks.

Delete implemented as RPC, so check performed on server side.
Lock implemented as Put call, so check performed on client side.

Anyway client can use Put RPC to delete and lock EC chunks, but we do not forbid shooting ourselves in the foot.

Do not allow to delete or lock EC chunks. `Delete` implemented as RPC, so check performed on server side. `Lock` implemented as `Put` call, so check performed on client side. Anyway client can use `Put` RPC to delete and lock EC chunks, but we do not forbid shooting ourselves in the foot.
dstepanov-yadro added 3 commits 2024-06-28 14:51:16 +00:00
049a7f7c07 [#9999] fmt: Drop unused interfaces 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
b26a3e682f [#9999] deleteSvc: Do not allow to delete EC chunks 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
DCO action / DCO (pull_request) Successful in 5m49s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 15m6s Details
Vulncheck / Vulncheck (pull_request) Successful in 17m14s Details
Build / Build Components (1.22) (pull_request) Successful in 17m19s Details
Tests and linters / gopls check (pull_request) Successful in 18m17s Details
Build / Build Components (1.21) (pull_request) Successful in 18m37s Details
Tests and linters / Staticcheck (pull_request) Successful in 21m28s Details
Tests and linters / Lint (pull_request) Successful in 21m29s Details
Tests and linters / Tests (1.22) (pull_request) Failing after 26m2s Details
Tests and linters / Tests with -race (pull_request) Failing after 32m11s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 42m14s Details
3fe753959d [#9999] cli: Do not allow to lock EC chunks 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/lock_ec_chunk from 3fe753959d to 5196c79eff 2024-06-28 14:53:04 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-06-28 14:59:20 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-06-28 15:00:28 +00:00
dstepanov-yadro force-pushed fix/lock_ec_chunk from 5196c79eff to 287a2431b7 2024-06-28 15:04:54 +00:00 Compare
dstepanov-yadro added 1 commit 2024-06-28 19:37:12 +00:00
DCO action / DCO (pull_request) Successful in 4m15s Details
Vulncheck / Vulncheck (pull_request) Successful in 4m37s Details
Build / Build Components (1.21) (pull_request) Successful in 5m8s Details
Build / Build Components (1.22) (pull_request) Successful in 5m1s Details
Tests and linters / gopls check (pull_request) Successful in 5m23s Details
Tests and linters / Staticcheck (pull_request) Successful in 6m6s Details
Tests and linters / Lint (pull_request) Successful in 7m30s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 9m10s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 10m32s Details
Tests and linters / Tests with -race (pull_request) Successful in 10m32s Details
Tests and linters / Tests (1.22) (pull_request) Successful in 11m10s Details
77866f6715 [#1213] engine: Drop unused 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
acid-ant approved these changes 2024-07-01 06:25:50 +00:00
fyrchik approved these changes 2024-07-01 06:49:20 +00:00
fyrchik merged commit 7a8ac4907a into master 2024-07-01 06:49:41 +00:00
fyrchik referenced this issue from a commit 2024-07-01 06:49:42 +00:00
[#1213] engine: Drop unused
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1213
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-node:fix/lock_ec_chunk"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?