TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

morph/client: Remove duplicate utility functions #1220

Merged
fyrchik merged 1 commit from elebedeva/frostfs-node:feat/refactor-morph-client into master 2024-07-02 13:01:46 +00:00
Conversation 0 Commits 1 Files changed 3 +3 -201
elebedeva commented 2024-07-02 12:25:16 +00:00
Member
Copy link

Close #1196

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1196 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added 1 commit 2024-07-02 12:25:29 +00:00
[#1196] morph/client: Remove duplicate utility functions
All checks were successful
Build / Build Components (1.21) (pull_request) Successful in 4m1s
Details
DCO action / DCO (pull_request) Successful in 4m3s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m51s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 5m15s
Details
Tests and linters / Lint (pull_request) Successful in 6m59s
Details
Build / Build Components (1.22) (pull_request) Successful in 8m54s
Details
Tests and linters / gopls check (pull_request) Successful in 10m46s
Details
Tests and linters / Staticcheck (pull_request) Successful in 11m30s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 13m37s
Details
Tests and linters / Tests (1.22) (pull_request) Successful in 13m43s
Details
Tests and linters / Tests with -race (pull_request) Successful in 13m44s
Details
259007540f 
We used several utility functions to parse frostfsid client
subject and extended subject. However, following the changes
in TrueCloudLab/frostfs-contract#97, these utility functions
have become public. So there is no more need to have them here.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
fyrchik approved these changes 2024-07-02 12:35:28 +00:00
achuprov approved these changes 2024-07-02 12:47:40 +00:00
acid-ant approved these changes 2024-07-02 12:52:37 +00:00
fyrchik merged commit 259007540f into master 2024-07-02 13:01:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
achuprov
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1220
No description provided.
Delete branch "elebedeva/frostfs-node:feat/refactor-morph-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?