TrueCloudLab
/
frostfs-node
17
1
Fork 21
Code Issues 89 Pull Requests 8 Actions Projects Releases Activity

[#1227] morph/event: Release ants.Pool on listener stopping #1227

Merged
fyrchik merged 1 commits from dkirillov/frostfs-node:bugfix/release_ants_pool_in_event_listener into master 2024-07-04 10:55:17 +00:00
Conversation 0 Commits 1 Files Changed 1
dkirillov commented 2024-07-04 09:12:14 +00:00

I need this to be able to recreate listener when it stopped (because of lost connection in subscriber) and make goroutines not to leak

I need this to be able to recreate listener when it stopped (because of lost connection in subscriber) and make goroutines not to leak
dkirillov added 1 commit 2024-07-04 09:12:18 +00:00
Vulncheck / Vulncheck (pull_request) Successful in 4m18s Details
DCO action / DCO (pull_request) Failing after 6m59s Details
Build / Build Components (1.21) (pull_request) Successful in 8m47s Details
Tests and linters / gopls check (pull_request) Successful in 9m5s Details
Tests and linters / Lint (pull_request) Successful in 9m35s Details
Tests and linters / Staticcheck (pull_request) Successful in 10m1s Details
Build / Build Components (1.22) (pull_request) Successful in 9m55s Details
Tests and linters / Tests (1.21) (pull_request) Failing after 18m25s Details
Tests and linters / Tests with -race (pull_request) Failing after 18m59s Details
Tests and linters / Tests (1.22) (pull_request) Failing after 19m25s Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 39m32s Details
b567aa7b35 [#XX] morph/event: Release ants.Pool on listener stopping 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov changed title from WIP: [#XX] morph/event: Release ants.Pool on listener stopping to WIP: [#1227] morph/event: Release ants.Pool on listener stopping 2024-07-04 09:12:28 +00:00
dkirillov force-pushed bugfix/release_ants_pool_in_event_listener from b567aa7b35 to 1995da8d3c 2024-07-04 09:12:55 +00:00 Compare
dkirillov changed title from WIP: [#1227] morph/event: Release ants.Pool on listener stopping to [#1227] morph/event: Release ants.Pool on listener stopping 2024-07-04 09:12:59 +00:00
dkirillov requested review from storage-core-committers 2024-07-04 09:13:05 +00:00
dkirillov requested review from storage-core-developers 2024-07-04 09:13:38 +00:00
dstepanov-yadro approved these changes 2024-07-04 09:16:35 +00:00
elebedeva approved these changes 2024-07-04 09:24:42 +00:00
acid-ant approved these changes 2024-07-04 10:47:03 +00:00
fyrchik approved these changes 2024-07-04 10:53:03 +00:00
fyrchik merged commit cfd5e3d403 into master 2024-07-04 10:55:14 +00:00
dkirillov deleted branch bugfix/release_ants_pool_in_event_listener 2024-07-04 11:08:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
elebedeva
acid-ant
fyrchik
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1227
There is no content yet.
Delete Branch "dkirillov/frostfs-node:bugfix/release_ants_pool_in_event_listener"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?