cli: Add --quiet flag to the healthcheck command #1232

achuprov · 2024-07-05T16:12:48Z

achuprov commented

2024-07-05 16:12:48 +00:00

Close #1209
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Close #1209 Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

fyrchik requested changes 2024-07-05 18:19:19 +00:00

cmd/frostfs-cli/internal/commonflags/flags.go Outdated

					
				@ -56,0 +56,4 @@

					QuietFlag          = "quiet"

					QuietFlagShorthand = "q"

					QuietFlagUsage     = "Return only the exit code"

fyrchik commented

2024-07-05 18:18:27 +00:00

That is misleading: we have 0 exit code when the status is not ready.
Sth like Print nothing and exit with non-zero code on failure?

That is misleading: we have 0 exit code when the status is not ready. Sth like `Print nothing and exit with non-zero code on failure`?

cmd/frostfs-cli/modules/control/healthcheck.go Outdated

					
				@ -51,2 +57,4 @@

					verifyResponse(cmd, resp.GetSignature(), resp.GetBody())

					if quietFlag, _ := cmd.Flags().GetBool(commonflags.QuietFlag); quietFlag {

						if strings.Contains(resp.GetBody().GetHealthStatus().String(), healthcheckOKStatus) {

fyrchik commented

2024-07-05 18:19:14 +00:00

GetHealthStatus returns enum, we could compare numbers instead of strings.

`GetHealthStatus` returns enum, we could compare numbers instead of strings.

achuprov force-pushed feat/healthcheck_quiet from ac09fb7b79 to 4c6e986785

2024-07-08 08:16:47 +00:00

Compare

achuprov requested review from storage-core-committers 2024-07-08 08:20:16 +00:00

achuprov requested review from storage-core-developers 2024-07-08 08:20:19 +00:00

fyrchik requested changes 2024-07-08 14:47:58 +00:00

cmd/frostfs-cli/modules/control/healthcheck.go Outdated

					
				@ -51,2 +55,4 @@

					verifyResponse(cmd, resp.GetSignature(), resp.GetBody())

					if quietFlag, _ := cmd.Flags().GetBool(commonflags.QuietFlag); quietFlag {

						if *resp.GetBody().GetHealthStatus().Enum() == control.HealthStatus_READY {