cli: Fix netinfo output for empty unknown parameters #1236

achuprov · 2024-07-09T09:16:24Z

achuprov commented

2024-07-09 09:16:24 +00:00

Before:

$ ./bin/frostfs-cli netmap netinfo  -c /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml

...
FrostFS network configuration (other)
  SystemDNS: 636f6e7461696e6572
  value:

After:

$ ./bin/frostfs-cli netmap netinfo  -c /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml

...
FrostFS network configuration (other)
  SystemDNS: 636f6e7461696e6572
  value: ""

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Ref https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/232 Before: ``` $ ./bin/frostfs-cli netmap netinfo -c /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml ... FrostFS network configuration (other) SystemDNS: 636f6e7461696e6572 value: ``` After: ``` $ ./bin/frostfs-cli netmap netinfo -c /home/achuprov/Documents/work/frostfs-dev-env/wallets/conf.yml ... FrostFS network configuration (other) SystemDNS: 636f6e7461696e6572 value: "" ``` Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>

achuprov force-pushed feat/unknown_network_info_parameters from fabc602021 to afeaf01cea

2024-07-09 09:33:18 +00:00

Compare

achuprov changed title from ~~[#99999] cli: Fix netinfo output for empty unknown parameters~~ to cli: Fix netinfo output for empty unknown parameters

2024-07-09 09:36:06 +00:00

achuprov requested review from storage-core-committers 2024-07-09 09:54:34 +00:00

achuprov requested review from storage-core-developers 2024-07-09 09:54:35 +00:00

acid-ant approved these changes 2024-07-09 10:35:24 +00:00

fyrchik reviewed 2024-07-09 12:52:54 +00:00

cmd/frostfs-cli/modules/netmap/netinfo.go

					
				@ -52,3 +52,2 @@

						cmd.Println("FrostFS network configuration (other)")

						netInfo.IterateRawNetworkParameters(func(name string, value []byte) {

							cmd.Printf(format, name, hex.EncodeToString(value))

						netInfo.IterateRawNetworkParameters(func(name string, rawValue []byte) {

fyrchik commented

2024-07-09 12:52:51 +00:00

I personally think the perfect behaviour was fine (we expect hex, we get empty hex)

achuprov commented

2024-07-09 13:10:05 +00:00

I think we should display the empty value (just like with namespace). What do you think about nil?

I think we should display the empty value (just like with namespace). What do you think about `nil`?

fyrchik commented

2024-07-09 13:20:49 +00:00

The same thing to me.
But if everyone agrees we need this, empty would be less Go-specific.

The same thing to me. But if everyone agrees we need this, `empty` would be less Go-specific.

achuprov commented

2024-07-15 07:29:32 +00:00

@aarifullin / @dstepanov-yadro / @elebedeva What do you think?

aarifullin commented

2024-07-15 08:29:37 +00:00

We should keep in mind that any cli output may be parsed (like test results).

value: ""

and

value: 57277d7b

As we can see these output results are not the same format. Either we need to frame non-nil output to quotes or omit it for the first case. I think if we keep it in current format - that's OK.

We should keep in mind that any cli output *may be* parsed (like test results). ``` value: "" ``` and ``` value: 57277d7b ``` As we can see these output results are not the same format. Either we need to *frame* non-nil output to quotes or omit it for the first case. I think if we keep it in current format - that's OK.