TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 108 Pull requests 3 Projects Releases 1 Activity Actions

morph/client: Remove duplicate utility functions #1244

Merged
fyrchik merged 2 commits from elebedeva/frostfs-node:feat/refactor-morph-client into master 2024-09-04 19:51:10 +00:00
Conversation 0 Commits 2 Files changed 2 +17 -192
elebedeva commented 2024-07-11 13:43:39 +00:00
Member
Copy link

Close #1196

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1196 Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
elebedeva added the
refactoring
internal
 labels 2024-07-11 13:43:40 +00:00
elebedeva requested review from storage-core-committers 2024-07-11 13:44:43 +00:00
elebedeva requested review from storage-core-developers 2024-07-11 13:45:54 +00:00
fyrchik approved these changes 2024-07-11 14:02:22 +00:00
elebedeva force-pushed feat/refactor-morph-client from a55d81b26b to df54a93465 2024-07-11 14:07:00 +00:00 Compare
acid-ant approved these changes 2024-07-11 14:09:18 +00:00
achuprov approved these changes 2024-07-11 14:31:27 +00:00
aarifullin approved these changes 2024-07-11 16:11:53 +00:00
elebedeva force-pushed feat/refactor-morph-client from df54a93465 to 932de25318 2024-07-12 09:10:55 +00:00 Compare
aarifullin approved these changes 2024-07-12 09:27:38 +00:00
fyrchik requested changes 2024-07-12 12:55:12 +00:00
pkg/morph/client/util.go Outdated
@ -70,3 +70,3 @@
// ArrayFromStackItem returns the slice contract parameters from passed parameter.
//
// If passed parameter carries boolean false value, (nil, nil) returns.
// If passed parameter carries boolean false value, returns (nil, nil).
fyrchik commented 2024-07-12 12:55:10 +00:00
Owner
Copy link

Unrelated to the commit.

Unrelated to the commit.
elebedeva commented 2024-07-12 15:00:07 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik commented 2024-07-12 19:04:34 +00:00
Owner
Copy link

please, look at the DCO action result

please, look at the DCO action result
👍 1
fyrchik commented 2024-07-12 19:05:18 +00:00
Owner
Copy link

also, we could use morph: or morph/client: component to this new commit too

also, we could use `morph: ` or `morph/client: ` component to this new commit too
👍 1
elebedeva force-pushed feat/refactor-morph-client from 932de25318 to 5f260660b4 2024-07-12 14:59:18 +00:00 Compare
elebedeva force-pushed feat/refactor-morph-client from 5f260660b4 to d06e6354f4 2024-07-15 13:13:38 +00:00 Compare
elebedeva force-pushed feat/refactor-morph-client from d06e6354f4 to 39866a957c 2024-07-15 13:25:22 +00:00 Compare
fyrchik approved these changes 2024-07-15 13:36:27 +00:00
fyrchik merged commit 39866a957c into master 2024-07-15 15:59:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
achuprov
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1244
No description provided.
Delete branch "elebedeva/frostfs-node:feat/refactor-morph-client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?