TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 101 Pull requests 6 Projects Releases 1 Activity Actions

shard: Fix delete objects from FSTree #1261

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/delete_without_storage_id into master 2024-07-22 11:56:44 +00:00
Conversation 0 Commits 1 Files changed 1 +6
dstepanov-yadro commented 2024-07-22 11:00:20 +00:00
Member
Copy link

Replace nil storageID with empty like by shard.Get.
Without this fix every object greater than small_object_size required iteration over all of blobovniczas. This leads to performance degradation.

Replace nil storageID with empty like by shard.Get. Without this fix every object greater than `small_object_size` required iteration over all of blobovniczas. This leads to performance degradation.
dstepanov-yadro requested review from storage-core-committers 2024-07-22 11:01:51 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-07-22 11:01:57 +00:00
fyrchik reviewed 2024-07-22 11:03:49 +00:00
pkg/local_object_storage/shard/delete.go Outdated
@ -119,1 +119,4 @@
storageID := res.StorageID()
if storageID == nil {
// if storageID is nil it means:
// 1. object stored by FSTree, but blobstore expects in such case non-nil but empty storageID (see shard/get.go)
fyrchik commented 2024-07-22 11:03:49 +00:00
Owner
Copy link

Why is it nil here, when it is an explicit empty slice in Put?

Why is it `nil` here, when it is an explicit empty slice in `Put`?
dstepanov-yadro commented 2024-07-22 11:25:24 +00:00
Author
Member
Copy link

You are right, fixed.

You are right, fixed.
aarifullin approved these changes 2024-07-22 11:12:14 +00:00
dstepanov-yadro force-pushed fix/delete_without_storage_id from 0cc1f3a5ff to 56e79557e9 2024-07-22 11:22:39 +00:00 Compare
dstepanov-yadro force-pushed fix/delete_without_storage_id from 56e79557e9 to 9f0d22a97f 2024-07-22 11:25:55 +00:00 Compare
fyrchik approved these changes 2024-07-22 11:27:47 +00:00
dstepanov-yadro requested review from aarifullin 2024-07-22 11:28:22 +00:00
dstepanov-yadro force-pushed fix/delete_without_storage_id from 9f0d22a97f to 18182e578e 2024-07-22 11:38:37 +00:00 Compare
aarifullin approved these changes 2024-07-22 11:42:07 +00:00
achuprov approved these changes 2024-07-22 11:46:21 +00:00
fyrchik merged commit 18182e578e into master 2024-07-22 11:56:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1261
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/delete_without_storage_id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?