shard: Fix delete objects from FSTree #1261
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1261
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/delete_without_storage_id"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Replace nil storageID with empty like by shard.Get.
Without this fix every object greater than
small_object_size
required iteration over all of blobovniczas. This leads to performance degradation.@ -119,1 +119,4 @@
storageID := res.StorageID()
if storageID == nil {
// if storageID is nil it means:
// 1. object stored by FSTree, but blobstore expects in such case non-nil but empty storageID (see shard/get.go)
Why is it
nil
here, when it is an explicit empty slice inPut
?You are right, fixed.
0cc1f3a5ff
to56e79557e9
56e79557e9
to9f0d22a97f
9f0d22a97f
to18182e578e