shard: Fix delete objects from FSTree #1261

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/delete_without_storage_id into master 2024-07-22 11:56:44 +00:00

Replace nil storageID with empty like by shard.Get.
Without this fix every object greater than small_object_size required iteration over all of blobovniczas. This leads to performance degradation.

Replace nil storageID with empty like by shard.Get. Without this fix every object greater than `small_object_size` required iteration over all of blobovniczas. This leads to performance degradation.
dstepanov-yadro requested review from storage-core-committers 2024-07-22 11:01:51 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-07-22 11:01:57 +00:00
fyrchik reviewed 2024-07-22 11:03:49 +00:00
@ -119,1 +119,4 @@
storageID := res.StorageID()
if storageID == nil {
// if storageID is nil it means:
// 1. object stored by FSTree, but blobstore expects in such case non-nil but empty storageID (see shard/get.go)
Owner

Why is it nil here, when it is an explicit empty slice in Put?

Why is it `nil` here, when it is an explicit empty slice in `Put`?
Author
Member

You are right, fixed.

You are right, fixed.
aarifullin approved these changes 2024-07-22 11:12:14 +00:00
dstepanov-yadro force-pushed fix/delete_without_storage_id from 0cc1f3a5ff to 56e79557e9 2024-07-22 11:22:39 +00:00 Compare
dstepanov-yadro force-pushed fix/delete_without_storage_id from 56e79557e9 to 9f0d22a97f 2024-07-22 11:25:55 +00:00 Compare
fyrchik approved these changes 2024-07-22 11:27:47 +00:00
dstepanov-yadro requested review from aarifullin 2024-07-22 11:28:22 +00:00
dstepanov-yadro force-pushed fix/delete_without_storage_id from 9f0d22a97f to 18182e578e 2024-07-22 11:38:37 +00:00 Compare
aarifullin approved these changes 2024-07-22 11:42:07 +00:00
achuprov approved these changes 2024-07-22 11:46:21 +00:00
fyrchik merged commit 18182e578e into master 2024-07-22 11:56:44 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1261
No description provided.