TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 7 Projects Releases 1 Activity Actions

shard: Fix delete objects from FSTree #1261

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/delete_without_storage_id into master 2024-07-22 11:56:44 +00:00
Conversation 0 Commits 1 Files changed 1 +6
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/local_object_storage/shard/delete.go
View file

@ -117,6 +117,12 @@ func (s *Shard) deleteFromBlobstor(ctx context.Context, addr oid.Address) error
return err return err
} }
storageID := res.StorageID() storageID := res.StorageID()
if storageID == nil {
// if storageID is nil it means:
// 1. there is no such object
fyrchik commented 2024-07-22 11:03:49 +00:00
Outdated
Review
Copy link

Why is it nil here, when it is an explicit empty slice in Put?

Why is it `nil` here, when it is an explicit empty slice in `Put`?
dstepanov-yadro commented 2024-07-22 11:25:24 +00:00
Outdated
Review
Copy link

You are right, fixed.

You are right, fixed.
// 2. object stored by writecache: should not happen, as `validateWritecacheDoesntContainObject` called before `deleteFromBlobstor`
return nil
}
var delPrm common.DeletePrm var delPrm common.DeletePrm
delPrm.Address = addr delPrm.Address = addr