TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 8 Projects Releases 1 Activity Actions

action: Enable cache #1269

Closed
achuprov wants to merge 1 commit from achuprov/frostfs-node:feat/make_Forgejo_more_great into master
pull from: achuprov/frostfs-node:feat/make_Forgejo_more_great
merge into: TrueCloudLab:master
Conversation 5 Commits 1 Files changed 2 +2
achuprov commented 2024-07-23 14:27:49 +00:00
Member
Copy link

Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
elebedeva commented 2024-07-23 14:35:42 +00:00
Member
Copy link

Can you please clarify, why are you enabling cache in actions?

Can you please clarify, why are you enabling cache in actions?
👍 1
fyrchik commented 2024-07-23 14:42:43 +00:00
Owner
Copy link

Please, use the .forgejo: prefix, see git history for examples.

Please, use the `.forgejo:` prefix, see git history for examples.
george.bartolomey commented 2024-07-23 14:55:18 +00:00
Member
Copy link

Can you please clarify, why are you enabling cache in actions?

This will decrease server load noticeably.

> Can you please clarify, why are you enabling cache in actions? This will decrease server load noticeably.
👍 1
achuprov force-pushed feat/make_Forgejo_more_great from 7d0cec95b0 to 13a69afd19 2024-07-23 14:58:11 +00:00 Compare
achuprov force-pushed feat/make_Forgejo_more_great from 13a69afd19 to f25b601e0a 2024-07-23 15:00:43 +00:00 Compare
dstepanov-yadro approved these changes 2024-07-24 11:11:38 +00:00
fyrchik commented 2024-07-24 16:21:01 +00:00
Owner
Copy link

The motivation for change should be in the commit message, not in the form of +1 to a message.

This change directly affects actions, so I will not merge this until they are red.

The motivation for change should be in the commit message, not in the form of `+1` to a message. This change directly affects actions, so I will not merge this until they are red.
achuprov force-pushed feat/make_Forgejo_more_great from 706b88f6b3 to f25b601e0a 2024-07-25 07:40:54 +00:00 Compare
achuprov commented 2024-07-25 07:49:34 +00:00
Author
Member
Copy link

@elebedeva

Can you please clarify, why are you enabling cache in actions?

Enabling caching will save runner resources. However,, enabling caching seems to make the test more flaky (See: https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9489/jobs/0 or https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9460/jobs/1). Let's wait for update from Forjejo before turning this feature on.

@elebedeva > Can you please clarify, why are you enabling cache in actions? Enabling caching will save runner resources. However,, enabling caching seems to make the test more flaky (See: https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9489/jobs/0 or https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/9460/jobs/1). Let's wait for update from Forjejo before turning this feature on.
achuprov closed this pull request 2024-07-25 07:49:35 +00:00
Some checks failed
Vulncheck / Vulncheck (pull_request) Successful in 2m9s
Required
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m26s
Required
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 7m53s
Required
Details
Build / Build Components (1.21) (pull_request) Failing after 10m50s
Required
Details
Build / Build Components (1.22) (pull_request) Failing after 10m23s
Required
Details
DCO action / DCO (pull_request) Failing after 10m1s
Required
Details
Pre-commit hooks / Pre-commit (pull_request) Failing after 14m54s
Required
Details
Tests and linters / Lint (pull_request) Failing after 14m50s
Required
Details
Tests and linters / Tests (1.22) (pull_request) Failing after 14m46s
Required
Details
Tests and linters / Tests with -race (pull_request) Failing after 14m44s
Required
Details
Tests and linters / gopls check (pull_request) Failing after 14m34s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1269
No description provided.
Delete branch "achuprov/frostfs-node:feat/make_Forgejo_more_great"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?