TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 7 Projects Releases 1 Activity Actions

Fix head --raw request handling for EC #1271

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:fix/ec_head_raw into master 2024-09-04 19:51:10 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
dstepanov-yadro commented 2024-07-24 05:51:44 +00:00
Member
Copy link

Now head --raw requests can be processed not only on container node with request forwarding to container node. At the same time, such requests are now executed sequentially, as it is much easier to implement.

Also fix extra bug in EC assemble.

Now `head --raw` requests can be processed not only on container node with request forwarding to container node. At the same time, such requests are now executed sequentially, as it is much easier to implement. Also fix extra bug in EC assemble.
dstepanov-yadro force-pushed fix/ec_head_raw from 88f6186104 to 7fd7961dfa 2024-07-24 05:53:21 +00:00 Compare
dstepanov-yadro reviewed 2024-07-24 05:56:43 +00:00
pkg/services/object/get/assemblerec.go
@ -294,3 +238,3 @@
}
var addr oid.Address
addr.SetContainer(addr.Container())
addr.SetContainer(a.addr.Container())
dstepanov-yadro commented 2024-07-24 05:56:42 +00:00
Author
Member
Copy link

Shame on me

Shame on me
fyrchik commented 2024-07-24 06:59:03 +00:00
Owner
Copy link

It seems like another bug, what could happen here?

It seems like another bug, what could happen here?
dstepanov-yadro commented 2024-07-24 07:12:10 +00:00
Author
Member
Copy link

The local chunk was never taken in the assembly of the object.

The local chunk was never taken in the assembly of the object.
dstepanov-yadro reviewed 2024-07-24 05:59:11 +00:00
pkg/services/object/get/remote.go
@ -61,3 +69,4 @@
case errors.As(err, &errECInfo):
r.status = statusEC
r.err = r.infoEC.addRemote(string(info.PublicKey()), errECInfo.ECInfo())
if r.isRaw() {
dstepanov-yadro commented 2024-07-24 05:59:11 +00:00
Author
Member
Copy link

It can be written more simply, but it's clearer this way.

It can be written more simply, but it's clearer this way.
👍 1
fyrchik commented 2024-07-24 07:04:06 +00:00
Owner
Copy link

questionable, but ok

questionable, but ok
dstepanov-yadro requested review from storage-core-committers 2024-07-24 06:12:01 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-07-24 06:12:02 +00:00
fyrchik approved these changes 2024-07-24 07:04:14 +00:00
aarifullin approved these changes 2024-07-24 07:21:27 +00:00
aarifullin left a comment
Member
Copy link

OK with me

OK with me
dstepanov-yadro merged commit 7fd7961dfa into master 2024-07-24 07:27:18 +00:00
dstepanov-yadro deleted branch fix/ec_head_raw 2024-07-24 07:28:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1271
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/ec_head_raw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?