TrueCloudLab/frostfs-node
19
1
Fork 23
Code Issues 97 Pull requests 7 Projects Releases 1 Activity Actions

go.mod: Update neo-go version that fixes ws-client #1274

Merged
fyrchik merged 1 commit from aarifullin/frostfs-node:fix/wsconn_invalid into master 2024-07-26 12:39:59 +00:00
Conversation 0 Commits 1 Files changed 2 +1 -1
aarifullin commented 2024-07-25 19:57:18 +00:00
Member
Copy link
  • Update go.mod;
  • This neo-go package version contains fix for the wsclient that allows to morph event listener refresh the invalidated websocket connection to neo-go.

See also: TrueCloudLab/neoneo-go#1

* Update go.mod; * This neo-go package version contains fix for the wsclient that allows to morph event listener refresh the invalidated websocket connection to neo-go. See also: https://git.frostfs.info/TrueCloudLab/neoneo-go/pulls/1
aarifullin added the
bug
 label 2024-07-25 19:57:18 +00:00
aarifullin requested review from storage-core-committers 2024-07-25 19:57:43 +00:00
aarifullin requested review from storage-core-developers 2024-07-25 19:57:48 +00:00
aarifullin force-pushed fix/wsconn_invalid from 716fb75e4e to 21227e7803 2024-07-25 19:58:10 +00:00 Compare
fyrchik reviewed 2024-07-26 06:19:14 +00:00
fyrchik left a comment
Owner
Copy link

NACK, having no events is expected e.g. under the split-brain scenario.

NACK, having no events is expected e.g. under the split-brain scenario.
aarifullin changed title from morph: Reset the connection in case of event absence to WIP: morph: Reset the connection in case of event absence 2024-07-26 07:54:40 +00:00
aarifullin force-pushed fix/wsconn_invalid from 21227e7803 to dd459d399f 2024-07-26 11:21:41 +00:00 Compare
aarifullin changed title from WIP: morph: Reset the connection in case of event absence to go.mod: Update neo-go version that fixes ws-client 2024-07-26 11:23:03 +00:00
achuprov approved these changes 2024-07-26 12:19:24 +00:00
fyrchik merged commit dd459d399f into master 2024-07-26 12:39:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
achuprov
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1274
No description provided.
Delete branch "aarifullin/frostfs-node:fix/wsconn_invalid"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?