frostfs-cli: Allow to use external addresses first for object nodes
#1282
No reviewers
TrueCloudLab/storage-core-developers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1282
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/object_nodes_external_priority"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
If
object nodes
called out of cluster node,frostfs-cli
tries to connect to internal address first. Now external addresses used by default. Also added new flag to use internal addresses first.7b9d79f368
to5008779158
frostfs-cli: Use external addresses first forto frostfs-cli: Allow to use external addresses first forobject nodes
object nodes
@ -32,2 +32,3 @@
const (
verifyPresenceAllFlag = "verify-presence-all"
verifyPresenceAllFlag = "verify-presence-all"
preferExternalAddressesFlag = "prefer-external-addresses"
This should be the default, as
object nodes
is a client command and external addresses are exactly to be used by client.I don't think we ever need to change this behaviour, it seems like a kludge.
I discussed this with QA. The command is most often run manually from a node and should prefer internal addresses, but external addresses are needed to run autotests from another node.
I would like the interface of our CLI to NOT be shaped by the volatile desires of our QA team.
Ok, flag changed
5008779158
to29fa104849
We use
cli:
prefix for CLI changes, this was already discussed.I think I have already left similar comment.
29fa104849
toc49982d22a
Done
object nodes
#1285