frostfs-cli: Allow to use external addresses first for object nodes #1282

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/object_nodes_external_priority into master 2024-08-01 06:17:41 +00:00

If object nodes called out of cluster node, frostfs-cli tries to connect to internal address first. Now external addresses used by default. Also added new flag to use internal addresses first.

If `object nodes` called out of cluster node, `frostfs-cli` tries to connect to internal address first. Now external addresses used by default. Also added new flag to use internal addresses first.
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 7b9d79f368 to 5008779158 2024-07-30 12:50:45 +00:00 Compare
dstepanov-yadro changed title from frostfs-cli: Use external addresses first for object nodes to frostfs-cli: Allow to use external addresses first for object nodes 2024-07-30 12:50:58 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-07-30 12:53:45 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-07-30 12:53:45 +00:00
fyrchik reviewed 2024-07-30 14:10:19 +00:00
@ -32,2 +32,3 @@
const (
verifyPresenceAllFlag = "verify-presence-all"
verifyPresenceAllFlag = "verify-presence-all"
preferExternalAddressesFlag = "prefer-external-addresses"
Owner

This should be the default, as object nodes is a client command and external addresses are exactly to be used by client.
I don't think we ever need to change this behaviour, it seems like a kludge.

This should be the default, as `object nodes` is a client command and external addresses are exactly to be used by client. I don't think we ever need to change this behaviour, it seems like a kludge.
Author
Member

I discussed this with QA. The command is most often run manually from a node and should prefer internal addresses, but external addresses are needed to run autotests from another node.

I discussed this with QA. The command is most often run manually from a node and should prefer internal addresses, but external addresses are needed to run autotests from another node.
Owner

I would like the interface of our CLI to NOT be shaped by the volatile desires of our QA team.

I would like the interface of our CLI to NOT be shaped by the volatile desires of our QA team.
Author
Member

Ok, flag changed

Ok, flag changed
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 5008779158 to 29fa104849 2024-07-31 06:58:44 +00:00 Compare
fyrchik approved these changes 2024-07-31 08:00:19 +00:00
fyrchik reviewed 2024-08-01 05:47:27 +00:00
fyrchik left a comment
Owner

We use cli: prefix for CLI changes, this was already discussed.
I think I have already left similar comment.

We use `cli:` prefix for CLI changes, this was already discussed. I think I have already left similar comment.
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 29fa104849 to c49982d22a 2024-08-01 06:16:51 +00:00 Compare
Author
Member

We use cli: prefix for CLI changes, this was already discussed.
I think I have already left similar comment.

Done

> We use `cli:` prefix for CLI changes, this was already discussed. > I think I have already left similar comment. Done
fyrchik merged commit c49982d22a into master 2024-08-01 06:17:41 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1282
No description provided.