TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 106 Pull requests 4 Projects Releases 2 Activity Actions

frostfs-cli: Allow to use external addresses first for object nodes #1282

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/object_nodes_external_priority into master 2024-08-01 06:17:41 +00:00
Conversation 1 Commits 1 Files changed 1 +17 -6
dstepanov-yadro commented 2024-07-30 12:43:05 +00:00
Member
Copy link

If object nodes called out of cluster node, frostfs-cli tries to connect to internal address first. Now external addresses used by default. Also added new flag to use internal addresses first.

If `object nodes` called out of cluster node, `frostfs-cli` tries to connect to internal address first. Now external addresses used by default. Also added new flag to use internal addresses first.
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 7b9d79f368 to 5008779158 2024-07-30 12:50:45 +00:00 Compare
dstepanov-yadro changed title from frostfs-cli: Use external addresses first for object nodes to frostfs-cli: Allow to use external addresses first for object nodes 2024-07-30 12:50:58 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-07-30 12:53:45 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-07-30 12:53:45 +00:00
fyrchik reviewed 2024-07-30 14:10:19 +00:00
cmd/frostfs-cli/modules/object/nodes.go Outdated
@ -32,2 +32,3 @@
const (
verifyPresenceAllFlag = "verify-presence-all"
verifyPresenceAllFlag = "verify-presence-all"
preferExternalAddressesFlag = "prefer-external-addresses"
fyrchik commented 2024-07-30 14:10:16 +00:00
Owner
Copy link

This should be the default, as object nodes is a client command and external addresses are exactly to be used by client.
I don't think we ever need to change this behaviour, it seems like a kludge.

This should be the default, as `object nodes` is a client command and external addresses are exactly to be used by client. I don't think we ever need to change this behaviour, it seems like a kludge.
dstepanov-yadro commented 2024-07-30 14:46:53 +00:00
Author
Member
Copy link

I discussed this with QA. The command is most often run manually from a node and should prefer internal addresses, but external addresses are needed to run autotests from another node.

I discussed this with QA. The command is most often run manually from a node and should prefer internal addresses, but external addresses are needed to run autotests from another node.
fyrchik commented 2024-07-30 16:32:04 +00:00
Owner
Copy link

I would like the interface of our CLI to NOT be shaped by the volatile desires of our QA team.

I would like the interface of our CLI to NOT be shaped by the volatile desires of our QA team.
dstepanov-yadro commented 2024-07-31 07:03:56 +00:00
Author
Member
Copy link

Ok, flag changed

Ok, flag changed
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 5008779158 to 29fa104849 2024-07-31 06:58:44 +00:00 Compare
fyrchik approved these changes 2024-07-31 08:00:19 +00:00
fyrchik reviewed 2024-08-01 05:47:27 +00:00
fyrchik left a comment
Owner
Copy link

We use cli: prefix for CLI changes, this was already discussed.
I think I have already left similar comment.

We use `cli:` prefix for CLI changes, this was already discussed. I think I have already left similar comment.
dstepanov-yadro force-pushed fix/object_nodes_external_priority from 29fa104849 to c49982d22a 2024-08-01 06:16:51 +00:00 Compare
dstepanov-yadro commented 2024-08-01 06:17:19 +00:00
Author
Member
Copy link

We use cli: prefix for CLI changes, this was already discussed.
I think I have already left similar comment.

Done

> We use `cli:` prefix for CLI changes, this was already discussed. > I think I have already left similar comment. Done
fyrchik merged commit c49982d22a into master 2024-08-01 06:17:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1282
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/object_nodes_external_priority"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?