Specify gofumpt version in the Makefile #1286

elebedeva · 2024-08-01T11:49:26Z

elebedeva commented

2024-08-01 11:49:26 +00:00

Add target to install gofumpt, fix target to run gofumpt, add gofumpt job to run on PR.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1266 Add target to install gofumpt, fix target to run gofumpt, add gofumpt job to run on PR. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

Infrastructure

internal

labels 2024-08-01 11:49:26 +00:00

elebedeva requested review from storage-core-committers 2024-08-01 11:49:46 +00:00

elebedeva requested review from storage-core-developers 2024-08-01 11:49:50 +00:00

fyrchik reviewed 2024-08-01 11:51:09 +00:00

Makefile Outdated

					
				@ -168,2 +177,3 @@

				# Run gofumpt

				fumpt:

				fumpt-run:

fyrchik commented

2024-08-01 11:50:59 +00:00

I wouldn't change the name of an already-existing target

👍 1

elebedeva commented

2024-08-01 12:11:23 +00:00

fixed

fyrchik marked this conversation as resolved

elebedeva force-pushed feat/fumpt-install from 80b770dd65 to 2902e0b68a

2024-08-01 12:10:51 +00:00

Compare

fyrchik approved these changes 2024-08-01 13:42:39 +00:00

fyrchik reviewed 2024-08-01 13:44:59 +00:00

fyrchik left a comment

Makefile prefix is ok too, we already use it.
If you feel energetic, please, split this in 2 commits (1 for Makefile: and ability to install, another for .forgejo: and running automatically).

`Makefile` prefix is ok too, we already use it. If you feel energetic, please, split this in 2 commits (1 for `Makefile:` and ability to install, another for `.forgejo:` and running automatically).

👀 1

dstepanov-yadro approved these changes 2024-08-01 13:49:05 +00:00

elebedeva force-pushed feat/fumpt-install from 2902e0b68a to ef4cea6d19

2024-08-02 09:37:49 +00:00

Compare

fyrchik merged commit ef4cea6d19 into master

2024-08-02 10:23:26 +00:00

Sign in to join this conversation.

No reviewers