TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 103 Pull requests 5 Projects Releases 2 Activity Actions

Specify gofumpt version in the Makefile #1286

Merged
fyrchik merged 2 commits from elebedeva/frostfs-node:feat/fumpt-install into master 2024-09-04 19:51:10 +00:00
Conversation 0 Commits 2 Files changed 2 +14 -1
1 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit a55600893e - Show all commits

15
Makefile
View file

@ -46,6 +46,10 @@ STATICCHECK_VERSION_DIR ?= $(STATICCHECK_DIR)/$(STATICCHECK_VERSION)
SOURCES = $(shell find . -type f -name "*.go" -print)
GOFUMPT_VERSION ?= v0.6.0
GOFUMPT_DIR ?= $(abspath $(BIN))/gofumpt
GOFUMPT_VERSION_DIR ?= $(GOFUMPT_DIR)/$(GOFUMPT_VERSION)
GOPLS_VERSION ?= v0.15.1
GOPLS_DIR ?= $(abspath $(BIN))/gopls
GOPLS_VERSION_DIR ?= $(GOPLS_DIR)/$(GOPLS_VERSION)
@ -165,10 +169,19 @@ imports:
@echo "⇒ Processing goimports check"
@goimports -w cmd/ pkg/ misc/
# Install gofumpt
fumpt-install:
@rm -rf $(GOFUMPT_DIR)
@mkdir $(GOFUMPT_DIR)
@GOBIN=$(GOFUMPT_VERSION_DIR) go install mvdan.cc/gofumpt@$(GOFUMPT_VERSION)
# Run gofumpt
fumpt:
fyrchik marked this conversation as resolved Outdated
fyrchik commented 2024-08-01 11:50:59 +00:00
Outdated
Review
Copy link

I wouldn't change the name of an already-existing target

I wouldn't change the name of an already-existing target
👍 1
elebedeva commented 2024-08-01 12:11:23 +00:00
Outdated
Review
Copy link

fixed

fixed
@if [ ! -d "$(GOFUMPT_VERSION_DIR)" ]; then \
make fumpt-install; \
fi
@echo "⇒ Processing gofumpt check"
@gofumpt -l -w cmd/ pkg/ misc/
$(GOFUMPT_VERSION_DIR)/gofumpt -l -w cmd/ pkg/ misc/
# Run Unit Test with go test
test: GOFLAGS ?= "-count=1"