sdnotify: Get rid of go:linkname for nanotime #1290

elebedeva · 2024-08-02T13:52:15Z

elebedeva commented

2024-08-02 13:52:15 +00:00

Replace runtime.nanotime() + go:linkname with time.Now() + time.Since().

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1262 Replace `runtime.nanotime() + go:linkname` with `time.Now() + time.Since()`. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

frostfs-ir

frostfs-node

internal

labels 2024-08-02 13:52:15 +00:00

elebedeva requested review from storage-core-committers 2024-08-02 13:52:54 +00:00

elebedeva requested review from storage-core-developers 2024-08-02 13:52:57 +00:00

dstepanov-yadro approved these changes 2024-08-02 15:14:46 +00:00

fyrchik reviewed 2024-08-05 07:42:26 +00:00

pkg/util/sdnotify/sdnotify.go Outdated

					
				@ -22,2 +24,4 @@

				)

				func init() {

					start = time.Now()

fyrchik commented

2024-08-05 07:42:19 +00:00

var start = time.Now() will suffice, no need for init().

`var start = time.Now()` will suffice, no need for `init()`.

elebedeva commented

2024-08-05 08:25:40 +00:00

fixed

elebedeva force-pushed fix/go-linkname-nanotime from 81b6f98b71 to 499485c5ae

2024-08-05 08:24:29 +00:00

Compare

aarifullin approved these changes 2024-08-05 09:18:40 +00:00

fyrchik approved these changes 2024-08-05 12:35:57 +00:00

fyrchik merged commit 327d364f34 into master

2024-08-05 12:37:19 +00:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1290