sdnotify: Send system monotonic time on reload #1314

elebedeva · 2024-08-15T14:22:22Z

elebedeva commented

2024-08-15 14:22:22 +00:00

Turns out that MONOTONIC_USEC field required by systemd on reload must be the system CLOCK_MONOTONIC timestamp at
the time the notification message was generated as systemd compares it to other CLOCK_MONOTONIC timestamps taken by pid1.

In the Go standard library the absolute monotonic timestamps in time.Time values are not made available to programmers.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1262 Turns out that `MONOTONIC_USEC` field required by `systemd` on reload must be the system `CLOCK_MONOTONIC` timestamp at the time the notification message was generated as `systemd` compares it to other `CLOCK_MONOTONIC` timestamps taken by pid1. In the Go standard library the absolute monotonic timestamps in `time.Time` values are not made available to programmers. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

frostfs-ir

frostfs-node

internal

labels 2024-08-15 14:22:22 +00:00

elebedeva requested review from storage-core-committers 2024-08-15 14:23:05 +00:00

elebedeva requested review from storage-core-developers 2024-08-15 14:23:07 +00:00

acid-ant approved these changes 2024-08-15 14:35:07 +00:00

fyrchik requested changes 2024-08-15 16:31:38 +00:00

pkg/util/sdnotify/sdnotify.go Outdated

					
				@ -17,6 +20,7 @@ const (

				var (

					socket *net.UnixAddr

					errMonotonicClockNotAvaliable = errors.New("unable to send RELOADING: monotonic clock is not available on this system")

fyrchik commented

2024-08-15 16:31:30 +00:00

unable to send RELOADING will be logged by the outer function, no need to include context here
is not available can be misleading, there are multiple possible return codes for this syscall.
How about return fmt.Errorf("clock_gettime: %w", err) in the function, without this variable?

`unable to send RELOADING` will be logged by the outer function, no need to include context here `is not available` can be misleading, there are multiple possible return codes for this syscall. How about `return fmt.Errorf("clock_gettime: %w", err)` in the function, without this variable?

elebedeva commented

2024-08-16 09:07:11 +00:00

fixed