TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

writecache: Drop unused #1359

Merged
acid-ant merged 1 commit from dstepanov-yadro/frostfs-node:fix/wc_drop_compressed into master 2024-09-10 06:15:19 +00:00
Conversation 1 Commits 1 Files changed 2 -13
dstepanov-yadro commented 2024-09-09 15:44:54 +00:00
Member
Copy link

Drop unused fields.

Looks like usage was deleted here: b64b14eb54

As we don't use compression, it shouldn't be a memory leak.

Drop unused fields. Looks like usage was deleted here: https://git.frostfs.info/TrueCloudLab/frostfs-node/commit/b64b14eb54cac04a27049e9eb0ef6fc414a85d59 As we don't use compression, it shouldn't be a memory leak.
dstepanov-yadro added 1 commit 2024-09-09 15:44:54 +00:00
[#9999] writecache: Drop unused
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 1m37s
Details
DCO action / DCO (pull_request) Successful in 2m33s
Details
Vulncheck / Vulncheck (pull_request) Successful in 3m32s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m52s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 4m7s
Details
Tests and linters / Lint (pull_request) Successful in 4m15s
Details
Tests and linters / gopls check (pull_request) Successful in 6m1s
Details
Build / Build Components (pull_request) Successful in 6m19s
Details
Tests and linters / Tests (pull_request) Successful in 7m35s
Details
Tests and linters / Tests with -race (pull_request) Successful in 7m39s
Details
91d6f11792 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/wc_drop_compressed from 91d6f11792 to 92fe5d90f5 2024-09-09 15:46:09 +00:00 Compare
dstepanov-yadro changed title from writecache: Drop unused to writecache: Drop unused (and memory leak) 2024-09-09 15:47:00 +00:00
dstepanov-yadro changed title from writecache: Drop unused (and memory leak) to writecache: Drop unused 2024-09-09 15:47:33 +00:00
dstepanov-yadro requested review from storage-core-committers 2024-09-09 15:47:52 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-09 15:47:57 +00:00
fyrchik approved these changes 2024-09-10 03:36:12 +00:00
fyrchik commented 2024-09-10 03:37:01 +00:00
Owner
Copy link

I though linter could catch such cases...

I though linter could catch such cases...
acid-ant approved these changes 2024-09-10 06:15:06 +00:00
acid-ant merged commit 92fe5d90f5 into master 2024-09-10 06:15:19 +00:00
acid-ant referenced this pull request from a commit 2024-09-10 06:15:22 +00:00
[#1359] writecache: Drop unused
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1359
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/wc_drop_compressed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?