TrueCloudLab
/
frostfs-node
18
1
Fork 20
Code Issues 88 Pull Requests 7 Actions Releases Activity

Revert "[#2260] services/object: Do not assemble object with TTL=1" #136

Merged
fyrchik merged 1 commits from carpawell/frostfs-node:fix/assembling-with-redirect into master 2023-03-20 07:58:34 +00:00
Conversation 2 Commits 1 Files Changed 1
carpawell commented 2023-03-13 21:27:29 +00:00
Collaborator

This allows big object assembling after redirecting. Failover test have been rechecked without that commit by @anikeev-yadro.

This allows big object assembling after redirecting. Failover test have been rechecked without that commit by @anikeev-yadro.
carpawell added the
frostfs-node
P0
 labels 2023-03-13 21:27:29 +00:00
carpawell self-assigned this 2023-03-13 21:27:29 +00:00
carpawell requested review from storage-core-developers 2023-03-13 21:28:34 +00:00
acid-ant approved these changes 2023-03-14 06:33:17 +00:00
fyrchik commented 2023-03-14 07:00:54 +00:00
Owner

Could you describe the reason in the commit message? Because without PR link it is hard to guess.

Could you describe the reason in the commit message? Because without PR link it is hard to guess.
carpawell force-pushed fix/assembling-with-redirect from c85c4727a9 to 3f2af754bf 2023-03-15 00:38:01 +00:00 Compare
carpawell commented 2023-03-15 00:38:45 +00:00
Poster
Collaborator

@fyrchik, added both PR number (i've found examples of such a reverting before) and some words about the reasons.

@fyrchik, added both PR number (i've found examples of such a reverting before) and some words about the reasons.
fyrchik removed the
P0
 label 2023-03-17 06:48:31 +00:00
fyrchik approved these changes 2023-03-17 06:48:56 +00:00
carpawell force-pushed fix/assembling-with-redirect from 3f2af754bf to abd21f8099 2023-03-20 07:52:33 +00:00 Compare
fyrchik merged commit abd21f8099 into master 2023-03-20 07:58:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
badger

Badger DB related issues   
frostfs-adm
   
frostfs-cli
   
frostfs-ir
   
frostfs-lens
   
frostfs-node
   
good first issue

Good for newcomers   
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
carpawell
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#136
There is no content yet.
Delete Branch "carpawell/frostfs-node:fix/assembling-with-redirect"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?