TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Upgrade google.golang.org/grpc version #1374

Merged
dstepanov-yadro merged 1 commit from dstepanov-yadro/frostfs-node:feat/upgrade_grpc_version into master 2024-10-26 11:30:26 +00:00
Conversation 2 Commits 1 Files changed 2 +26 -9
dstepanov-yadro commented 2024-09-13 09:03:14 +00:00
Member
Copy link

For frostfs-cli tree ... and tree syncing it is ok to defer dial to first RPC call.
For tree cache use Healthcheck call to dial.

For `frostfs-cli tree ...` and tree syncing it is ok to defer dial to first RPC call. For tree cache use `Healthcheck` call to dial.
dstepanov-yadro added 4 commits 2024-09-13 09:03:15 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
For `frostfs-cli` it is ok to use grpc-client without blocking,
as `frostfs-cli` will perform RPC call anyway.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Created connection will be used to sync trees, so it is ok to defer
dial to the first RPC call.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] tree: Use NewClient to create grpc connection in cache
All checks were successful
DCO action / DCO (pull_request) Successful in 50s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m46s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m20s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m33s
Details
Build / Build Components (pull_request) Successful in 2m36s
Details
Tests and linters / gopls check (pull_request) Successful in 2m58s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m3s
Details
Tests and linters / Tests with -race (pull_request) Successful in 3m44s
Details
Tests and linters / Lint (pull_request) Successful in 3m48s
Details
Tests and linters / Tests (pull_request) Successful in 7m1s
Details
22d95e4454 
Created grpc connection should be established, so perform Healthcheck request
to check connection is ok.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/upgrade_grpc_version from 22d95e4454 to e100d57662 2024-09-13 09:04:38 +00:00 Compare
fyrchik reviewed 2024-09-13 09:36:09 +00:00
cmd/frostfs-cli/modules/tree/client.go Outdated
@ -47,3 +40,1 @@
cc, err := grpc.DialContext(ctx, netAddr.URIAddr(), opts...)
cancel()
cc, err := grpc.NewClient(netAddr.URIAddr(), opts...)
fyrchik commented 2024-09-13 09:34:10 +00:00
Owner
Copy link

It changes the behaviour if the service is unavailable.
Before we have failed after 2 seconds what is the timeout now?

It changes the behaviour if the service is unavailable. Before we have failed after 2 seconds what is the timeout now?
dstepanov-yadro commented 2024-09-13 10:24:18 +00:00
Author
Member
Copy link

Fixed: user defined one

Fixed: user defined one
pkg/services/tree/cache.go Outdated
@ -111,0 +120,4 @@
ctx, cancel := context.WithTimeout(ctx, defaultClientConnectTimeout)
defer cancel()
// perform some request to check connection
if _, err := NewTreeServiceClient(cc).Healthcheck(ctx, req); err != nil {
fyrchik commented 2024-09-13 09:35:38 +00:00
Owner
Copy link

Can we use only connection methods, like WaitForStateChange?

Can we use only connection methods, like `WaitForStateChange`?
dstepanov-yadro commented 2024-09-13 10:26:12 +00:00
Author
Member
Copy link

I checked the option with WaitForStateChange, but it requires cc.Connect() call which is experimental. So I decided to perform regualr RPC request.

image

I checked the option with `WaitForStateChange`, but it requires `cc.Connect()` call which is experimental. So I decided to perform regualr RPC request. ![image](/attachments/1d88b92d-ef48-4de9-b9aa-12d20ddf9495)
image.png
47 KiB
dstepanov-yadro force-pushed feat/upgrade_grpc_version from e100d57662 to 4287223662 2024-09-13 10:24:18 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-09-13 12:04:51 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-09-13 12:04:52 +00:00
dstepanov-yadro force-pushed feat/upgrade_grpc_version from 4287223662 to 471b0435d3 2024-09-13 12:27:44 +00:00 Compare
acid-ant approved these changes 2024-09-13 12:31:52 +00:00
fyrchik approved these changes 2024-09-13 12:44:47 +00:00
Dismissed
fyrchik commented 2024-09-13 12:45:24 +00:00
Owner
Copy link

The last commit has invalid # number
The last commit has invalid prefix (we use go.mod:)

The last commit has invalid # number The last commit has invalid prefix (we use `go.mod:`)
fyrchik dismissed fyrchik's review 2024-09-13 12:45:30 +00:00
dstepanov-yadro force-pushed feat/upgrade_grpc_version from 471b0435d3 to 89d0435b1d 2024-09-13 12:59:41 +00:00 Compare
dstepanov-yadro commented 2024-09-13 12:59:46 +00:00
Author
Member
Copy link

The last commit has invalid # number
The last commit has invalid prefix (we use go.mod:)

Fixed

> The last commit has invalid # number > The last commit has invalid prefix (we use `go.mod:`) Fixed
fyrchik approved these changes 2024-09-13 13:00:31 +00:00
dstepanov-yadro merged commit 89d0435b1d into master 2024-09-13 13:09:33 +00:00
dstepanov-yadro deleted branch feat/upgrade_grpc_version 2024-09-13 13:10:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1374
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/upgrade_grpc_version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?