.forgejo: Make 'fumpt' job fail on changed files #1376

Merged

fyrchik merged 1 commit from elebedeva/frostfs-node:fix/fumpt-action into master 2024-09-13 15:12:31 +00:00

Conversation 0 Commits 1 Files changed 1 +3 -1

elebedeva commented 2024-09-13 12:57:38 +00:00

Member

Copy link

Close #1266

gofumpt always returns an exit code of 0, even when it finds misformatted files. To make fumpt action behave as expected we need to check if gofumpt changed any files.

Thanks to @a-savchuk for this fix.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1266 `gofumpt` always returns an exit code of 0, even when it finds misformatted files. To make `fumpt` action behave as expected we need to check if `gofumpt` changed any files. Thanks to @a-savchuk for this fix. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

Infrastructure

internal

labels 2024-09-13 12:57:38 +00:00

elebedeva added 1 commit 2024-09-13 12:57:38 +00:00

[#1266] .forgejo: Make 'fumpt' job fail on changed files ... 0a93738042

`gofumpt` always returns an exit code of 0, even when it finds
misformatted files. To make `fumpt` action behave as expected
we need to check if `gofumpt` changed any files.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva changed title from .forgejo: Make 'fumpt' job fail on changed files to WIP: .forgejo: Make 'fumpt' job fail on changed files 2024-09-13 12:58:30 +00:00

fyrchik requested review from storage-core-committers 2024-09-13 12:59:20 +00:00

fyrchik requested review from storage-core-developers 2024-09-13 12:59:24 +00:00

elebedeva changed title from WIP: .forgejo: Make 'fumpt' job fail on changed files to .forgejo: Make 'fumpt' job fail on changed files 2024-09-13 13:51:53 +00:00

acid-ant approved these changes 2024-09-13 14:23:05 +00:00

elebedeva force-pushed fix/fumpt-action from 0a93738042 to 2be1aa781d 2024-09-13 14:28:10 +00:00 Compare

achuprov approved these changes 2024-09-13 14:47:22 +00:00

fyrchik merged commit 2be1aa781d into master 2024-09-13 15:12:31 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

acid-ant

achuprov

Labels

Clear labels   

P0

Highest

  

P1

High

  

P2

Medium

  

P3

Low

  

badger

Badger DB related issues

  

frostfs-adm

  

frostfs-cli

  

frostfs-ir

  

frostfs-lens

  

frostfs-node

  

good first issue

Good for newcomers

  

triage

  

Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  

blocked

The issue or PR is blocked by something

  

bug

Something is not working

  

config

Configuration format update or breaking change

  

discussion

Talking about something in order to reach a decision or to exchange ideas

  

documentation

Documentation related

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

go

Language features adoption

  

help wanted

Extra attention is needed

  

internal

  

invalid

Something is wrong

  

kludge

This is a kludge and we know it

  

observability

Related to metrics, tracing and logs

  

perfomance

Perfomance related

  

question

More information is needed

  

refactoring

Refactoring

  

wontfix

This won't be fixed

No labels

P0

P1

P2

P3

badger

frostfs-adm

frostfs-cli

frostfs-ir

frostfs-lens

frostfs-node

good first issue

triage

Infrastructure

blocked

bug

config

discussion

documentation

duplicate

enhancement

go

help wanted

internal

invalid

kludge

observability

perfomance

question

refactoring

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1376

No description provided.