Return AccessDenied error instead of ObjectNotFound #1378
No reviewers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1378
Loading…
Reference in a new issue
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/get_return_error_access_denied"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #1297
Now AccessDeniedError for object.get requests has higher priority.
Before:
After (preparation steps not included):
@ -42,3 +42,3 @@
if errors.As(err, &errAccessDenied) {
r.err = err
} else {
} else if r.err == nil || !errors.As(r.err, &errAccessDenied) {
Get request shouldn't stop in case of AccesssDeniedError, because it could be caused by local APE override.
This change corresponds to the PR description:
errAccessDenied
error should have higher priority overObjectNotFound
. That's ok.But for me this comment looks little bit complicating :)
processCurrentEpoch
won't stop byprocessNode
anyway as it returnsfalse
. How shouldn't it stop then?with
lookupDepth == 0
condition:WIP: Return AccessDenied error instead of ObjectNotFoundto Return AccessDenied error instead of ObjectNotFound2d50b1cf0d
to4300dd3a41
4300dd3a41
to2aa07902eb
Please rebase on master.
2aa07902eb
tobdf386366c