node: Allow tombstone_lifetime config to be loaded on the fly #1405

elebedeva · 2024-10-01T13:44:24Z

elebedeva commented

2024-10-01 13:44:24 +00:00

Close #1306

Tested with dev-env.

Signed-off-by: Ekaterina Lebedeva ekaterina.lebedeva@yadro.com

Close #1306 Tested with `dev-env`. Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva added the

enhancement

frostfs-node

labels 2024-10-01 13:44:24 +00:00

elebedeva added 1 commit 2024-10-01 13:44:25 +00:00

[#1306 ] node: Allow tombstone_lifetime config to be loaded on the fly

DCO action / DCO (pull_request) Successful in 1m20s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 1m23s

Details

Vulncheck / Vulncheck (pull_request) Successful in 1m36s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m15s

Details

Build / Build Components (pull_request) Successful in 2m24s

Details

Tests and linters / gopls check (pull_request) Successful in 2m43s

Details

Tests and linters / Staticcheck (pull_request) Successful in 2m59s

Details

Tests and linters / Lint (pull_request) Successful in 3m25s

Details

Tests and linters / Tests (pull_request) Successful in 4m11s

Details

Tests and linters / Tests with -race (pull_request) Successful in 5m59s

Details

18a8aa75c8

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>

elebedeva requested review from storage-core-committers 2024-10-01 13:44:38 +00:00

elebedeva requested review from storage-core-developers 2024-10-01 13:44:42 +00:00

elebedeva force-pushed feat/tombstone-reload-config from 18a8aa75c8 to 2d9ad9792a

2024-10-01 14:31:06 +00:00

Compare

elebedeva force-pushed feat/tombstone-reload-config from 2d9ad9792a to 51b9a31ee3

2024-10-01 14:31:36 +00:00

Compare

acid-ant approved these changes 2024-10-02 06:06:12 +00:00

fyrchik reviewed 2024-10-02 06:21:20 +00:00

cmd/frostfs-node/config.go Outdated

					
				@ -106,2 +106,4 @@

					}

					ObjectCfg struct {

						tombstoneLifetime uint64

fyrchik commented

2024-10-02 06:21:17 +00:00

We have this uint64 and atomic in some other place.
Could you describe why can't we have a single atomic?

We have this `uint64` and atomic in some other place. Could you describe why can't we have a single atomic?

elebedeva commented

2024-10-02 07:21:30 +00:00

I wanted to maintain the style of readConfig() and reloadConfig() where parameters firstly stored in applicationConfiguration and then are reloaded.

I wanted to maintain the style of [readConfig()](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/51b9a31ee3c878a8aea440a69bf39a06545192ea/cmd/frostfs-node/config.go#L203) and [reloadConfig()](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/51b9a31ee3c878a8aea440a69bf39a06545192ea/cmd/frostfs-node/config.go#L1281) where parameters firstly stored in `applicationConfiguration` and then are reloaded.