TrueCloudLab/frostfs-node

Fork 27

adm: Properly check whether transfers were made #1409

Merged

fyrchik merged 1 commit from fyrchik/frostfs-node:adm-init into master

2024-10-26 11:30:27 +00:00

fyrchik commented

2024-10-02 08:42:05 +00:00

Owner

Close #1391
Also fix a bug in test introduced in #1372

Testing done: reproduced via TestInitialize by artificial block creation, after the fix test has passed.
I see no value in having this specific test to be run constantly, so omitted the changed.

Close #1391 Also fix a bug in test introduced in #1372 Testing done: reproduced via `TestInitialize` by artificial block creation, after the fix test has passed. I see no value in having this specific test to be run constantly, so omitted the changed.

fyrchik added 3 commits 2024-10-02 08:42:06 +00:00

[#1409 ] adm: Do not bind DeltaFlag to viper f45e75e3eb

We bind flag that could be specified in config.
This is not a config flag, just a command option.
Also fix TestInitialize failures:
```
                Error:          Received unexpected error:
                                number of epochs cannot be less than 1
                Test:           TestInitialize/16_nodes/force-new-epoch
```
Refs #1372 (945b7c740b)

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

[#1409 ] adm: Uncommonize DeltaFlag 62028cd7ee

It is used only in `force-new-epoch`, it is not _common_ between
multiple commands.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

[#1391 ] adm: Properly check whether transfers were made

DCO action / DCO (pull_request) Successful in 35s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 1m16s

Details

Vulncheck / Vulncheck (pull_request) Successful in 1m25s

Details

Build / Build Components (pull_request) Successful in 2m17s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m26s

Details

Tests and linters / gopls check (pull_request) Successful in 2m45s

Details

Tests and linters / Staticcheck (pull_request) Successful in 2m56s

Details

Tests and linters / Lint (pull_request) Successful in 3m32s

Details

Tests and linters / Tests (pull_request) Successful in 4m17s

Details

Tests and linters / Tests with -race (pull_request) Successful in 5m59s

Details

f83f7feb8c

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-10-02 08:42:37 +00:00

fyrchik requested review from storage-core-developers 2024-10-02 08:42:39 +00:00

dstepanov-yadro approved these changes 2024-10-02 09:01:14 +00:00

acid-ant approved these changes 2024-10-02 09:06:35 +00:00

fyrchik merged commit f83f7feb8c into master

2024-10-02 09:08:45 +00:00

fyrchik referenced this pull request from a commit

2024-10-02 09:08:47 +00:00

[#1409] adm: Do not bind DeltaFlag to viper

fyrchik referenced this pull request from a commit

2024-10-02 09:08:47 +00:00

[#1409] adm: Uncommonize DeltaFlag

fyrchik deleted branch adm-init

2024-10-02 09:08:48 +00:00

No reviewers

TrueCloudLab/storage-core-developers

No labels

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1409

No description provided.