metabase: Check parameter for CountAliveObjectsInBucket
#1414
No reviewers
TrueCloudLab/storage-core-developers
Labels
No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-node#1414
Loading…
Reference in a new issue
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/count-in-bucket"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com
CountAliveObjectsInBucket
d0f1c6d37b
tob96d5c9b02
@ -454,3 +454,2 @@
cidRaw := prm.BucketName[1:bucketKeySize]
if cidRaw == nil {
if prm.BucketName == nil {
if len(prm.BucketName) == 0
would be nicer, it prevents a possible panic which is not caught bynil
comparisonThanks, fixed.
BTW, it still can be less than the
bucketKeySize
Not for this PR: is there any reason we leak
BucketName
to the upper level?It seems enough to operate with some notion of
object type
andcontainer id
, both of which are already existing abstractions.Right, need to check for
bucketKeySize
. Updated.As for
BucketName
- no strong reason, just for quicker implementation and less compute.I'll update method signature - will use object type and container id.
b96d5c9b02
to026ef954b8
New commits pushed, approval review dismissed automatically according to repository settings
New commits pushed, approval review dismissed automatically according to repository settings
026ef954b8
to085c9921d2
085c9921d2
to2f710d8f94