TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

lens/explorer: Fix display text for locked object records #1429

Merged
acid-ant merged 1 commit from a-savchuk/frostfs-node:metabase-explorer-typo into master 2024-10-14 13:39:43 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
a-savchuk commented 2024-10-14 12:57:43 +00:00
Member
Copy link

Display texts for a locked object and a list of it lockers were mistakenly swapped. Based on

Lines 54 to 56 in acd6eb1
// lockedPrefix is used for storing locked objects information.
// Key: container ID
// Value: bucket mapping objects locked to the list of corresponding LOCK objects.

Before:
image

After:
image

Signed-off-by: Aleksey Savchuk a.savchuk@yadro.com

Display texts for a locked object and a list of it lockers were mistakenly swapped. Based on https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/acd6eb18151d7e2fec413d97e273b13076a9b4bb/pkg/local_object_storage/metabase/util.go#L54-L56 Before: ![image](/attachments/a57b96f3-f86e-4ecc-beae-8a8f48dbdb7a) After: ![image](/attachments/c72898a8-442b-4bcb-aa47-32ea7e9a1bb9) Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
image.png
69 KiB
image.png
66 KiB
a-savchuk added 1 commit 2024-10-14 12:57:43 +00:00
[#XX] lens/explorer: Fix locked object records display text
Some checks failed
DCO action / DCO (pull_request) Failing after 1m37s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m2s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m59s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m57s
Details
Tests and linters / gopls check (pull_request) Successful in 3m1s
Details
Build / Build Components (pull_request) Successful in 3m12s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m43s
Details
Tests and linters / Lint (pull_request) Successful in 4m0s
Details
Tests and linters / Tests (pull_request) Successful in 6m37s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m42s
Details
ff2bec8f71 
Display texts for a locked object and a list of it lockers were mistakenly swapped.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
a-savchuk force-pushed metabase-explorer-typo from ff2bec8f71 to d2a59b2de8 2024-10-14 12:58:39 +00:00 Compare
a-savchuk changed title from WIP: [#XX] lens/explorer: Fix locked object records display text to WIP: lens/explorer: Fix locked object records display text 2024-10-14 12:59:04 +00:00
a-savchuk changed title from WIP: lens/explorer: Fix locked object records display text to lens/explorer: Fix locked object records display text 2024-10-14 13:07:41 +00:00
a-savchuk changed title from lens/explorer: Fix locked object records display text to lens/explorer: Fix display text for locked object records 2024-10-14 13:11:25 +00:00
a-savchuk requested review from storage-core-developers 2024-10-14 13:11:57 +00:00
a-savchuk requested review from storage-core-committers 2024-10-14 13:11:58 +00:00
acid-ant approved these changes 2024-10-14 13:29:58 +00:00
achuprov approved these changes 2024-10-14 13:35:47 +00:00
acid-ant merged commit d2a59b2de8 into master 2024-10-14 13:39:43 +00:00
a-savchuk deleted branch metabase-explorer-typo 2024-10-14 14:36:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1429
No description provided.
Delete branch "a-savchuk/frostfs-node:metabase-explorer-typo"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?