TrueCloudLab/frostfs-node
19
1
Fork 27
Code Issues 91 Pull requests 6 Projects Releases 1 Activity Actions

sdnotify: Fix status for RELOADING #1440

Merged
acid-ant merged 1 commit from acid-ant/frostfs-node:bugfix/sdnotify into master 2024-10-21 11:55:59 +00:00
Conversation 1 Commits 1 Files changed 1 +2
acid-ant commented 2024-10-21 11:15:04 +00:00
Member
Copy link

Before:

RELOADING=1
MONOTONIC_USEC=17951246687
STATUS=RELOADING=1
MONOTONIC_USEC=17951246687

After:

RELOADING=1
MONOTONIC_USEC=17951246687
STATUS=RELOADING

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Before: ``` RELOADING=1 MONOTONIC_USEC=17951246687 STATUS=RELOADING=1 MONOTONIC_USEC=17951246687 ``` After: ``` RELOADING=1 MONOTONIC_USEC=17951246687 STATUS=RELOADING ``` Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant added 1 commit 2024-10-21 11:15:04 +00:00
[#xx] sdnotify: Fix status for RELOADING
Some checks failed
DCO action / DCO (pull_request) Failing after 2m18s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m15s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m37s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m8s
Details
Tests and linters / gopls check (pull_request) Successful in 4m21s
Details
Tests and linters / Lint (pull_request) Successful in 4m45s
Details
Build / Build Components (pull_request) Successful in 4m54s
Details
Tests and linters / Tests (pull_request) Successful in 6m55s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m56s
Details
5be7aa3545 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant requested review from storage-core-committers 2024-10-21 11:15:16 +00:00
acid-ant requested review from storage-core-developers 2024-10-21 11:15:20 +00:00
acid-ant force-pushed bugfix/sdnotify from 5be7aa3545 to 60911b7cb1 2024-10-21 11:15:37 +00:00 Compare
dstepanov-yadro approved these changes 2024-10-21 11:19:02 +00:00
fyrchik reviewed 2024-10-21 11:22:33 +00:00
pkg/util/sdnotify/sdnotify.go Outdated
@ -59,6 +59,8 @@ func FlagAndStatus(status string) error {
return fmt.Errorf("clock_gettime: %w", err)
}
status += "\nMONOTONIC_USEC=" + strconv.FormatInt(ts.Nano()/1000, 10)
status += "\nSTATUS=RELOADING"
fyrchik commented 2024-10-21 11:22:33 +00:00
Owner
Copy link

What is the difference with the previous implementation?

What is the difference with the previous implementation?
fyrchik approved these changes 2024-10-21 11:24:01 +00:00
acid-ant force-pushed bugfix/sdnotify from 60911b7cb1 to 8b6ec57c61 2024-10-21 11:25:37 +00:00 Compare
acid-ant commented 2024-10-21 11:25:50 +00:00
Author
Member
Copy link

Commit message updated.

Commit message updated.
a-savchuk reviewed 2024-10-21 11:32:03 +00:00
pkg/util/sdnotify/sdnotify.go
@ -59,6 +59,8 @@ func FlagAndStatus(status string) error {
return fmt.Errorf("clock_gettime: %w", err)
}
status += "\nMONOTONIC_USEC=" + strconv.FormatInt(ts.Nano()/1000, 10)
status += "\nSTATUS=RELOADING"
a-savchuk commented 2024-10-21 11:32:03 +00:00
Member
Copy link

Why not use this approach for other statuses as well? like READY=1 and STOPPING=1

Why not use this approach for other statuses as well? like READY=1 and STOPPING=1
elebedeva commented 2024-10-21 11:40:30 +00:00
Member
Copy link

Why using this approach in the first place? We already adding this line to status here

Why using this approach in the first place? We already adding this line to `status` [here](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/ed13387c0e1406040898fc91f36c6d9370f58413/pkg/util/sdnotify/sdnotify.go#L63)
elebedeva commented 2024-10-21 11:53:29 +00:00
Member
Copy link

Ah, I see, we added MONOTONIC_USEC to status, so just trimming suffix =1 doesn't work anymore in case of reloading.

But I still believe that for other statuses changing current behaviour is unnecessary.

Ah, I see, we added `MONOTONIC_USEC` to `status`, so just trimming suffix `=1` doesn't work anymore in case of reloading. But I still believe that for other statuses changing current behaviour is unnecessary.
fyrchik commented 2024-10-21 12:26:16 +00:00
Owner
Copy link

This line is inside if status == ReloadingEnabled, so only reloading is affected.
I think this answers both questions.

This line is inside `if status == ReloadingEnabled`, so only reloading is affected. I think this answers both questions.
a-savchuk marked this conversation as resolved
elebedeva approved these changes 2024-10-21 11:54:04 +00:00
acid-ant merged commit 8b6ec57c61 into master 2024-10-21 11:55:59 +00:00
acid-ant deleted branch bugfix/sdnotify 2024-10-21 11:56:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
fyrchik
elebedeva
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1440
No description provided.
Delete branch "acid-ant/frostfs-node:bugfix/sdnotify"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?