TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Fix data race on morph component init #1444

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:fix/resync_fail_morph_client into master 2024-10-23 10:25:35 +00:00
Conversation 2 Commits 1 Files changed 4 +13 -11
dstepanov-yadro commented 2024-10-23 07:41:18 +00:00
Member
Copy link

It could be called for every shard on metabase resync concurrently and
it is possible to get state with initialized client but not initialized
contract hashes.

It could be called for every shard on metabase resync concurrently and it is possible to get state with initialized client but not initialized contract hashes.
dstepanov-yadro added 1 commit 2024-10-23 07:41:19 +00:00
[#9999] config: Fix data race on morph component init
All checks were successful
DCO action / DCO (pull_request) Successful in 34s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 2m16s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m49s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m44s
Details
Build / Build Components (pull_request) Successful in 3m41s
Details
Tests and linters / gopls check (pull_request) Successful in 3m43s
Details
Tests and linters / Tests with -race (pull_request) Successful in 4m7s
Details
Tests and linters / Staticcheck (pull_request) Successful in 4m27s
Details
Tests and linters / Lint (pull_request) Successful in 5m8s
Details
Tests and linters / Tests (pull_request) Successful in 6m25s
Details
1ff7d9fb6a 
It could be called for every shard on metabase resync concurrently and
it is possible to get state with initialized client but not initialized
contract hashes.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed fix/resync_fail_morph_client from 1ff7d9fb6a to e515dd4582 2024-10-23 07:42:04 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-10-23 07:46:55 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-10-23 07:46:56 +00:00
fyrchik commented 2024-10-23 09:27:33 +00:00
Owner
Copy link

Why do we go to the network on resync?

Why do we go to the network on resync?
dstepanov-yadro commented 2024-10-23 09:31:03 +00:00
Author
Member
Copy link

Why do we go to the network on resync?

To get container properties (indexed or not)

> Why do we go to the network on resync? To get container properties (indexed or not)
acid-ant approved these changes 2024-10-23 09:33:49 +00:00
aarifullin approved these changes 2024-10-23 09:50:40 +00:00
aarifullin left a comment
Member
Copy link

Good!

Good!
fyrchik merged commit e515dd4582 into master 2024-10-23 10:25:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1444
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:fix/resync_fail_morph_client"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?