object: Make patch not set key before target construction #1458

Merged
dstepanov-yadro merged 1 commit from aarifullin/frostfs-node:fix/patch/sign into master 2024-10-29 15:20:29 +00:00
Member
  • SignRequestPrivateKey field should be initialized either within newUntrustedTarget or within newTrustedTarget. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node.
* `SignRequestPrivateKey` field should be initialized either within `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node.
aarifullin added the
bug
label 2024-10-29 14:20:43 +00:00
aarifullin added 1 commit 2024-10-29 14:20:44 +00:00
[#XX] object: Make patch not set key before target construction
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 1m34s
DCO action / DCO (pull_request) Failing after 1m47s
Vulncheck / Vulncheck (pull_request) Successful in 2m57s
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m9s
Build / Build Components (pull_request) Successful in 3m24s
Tests and linters / Staticcheck (pull_request) Successful in 3m19s
Tests and linters / gopls check (pull_request) Successful in 3m40s
Tests and linters / Lint (pull_request) Successful in 4m14s
Tests and linters / Tests (pull_request) Successful in 5m19s
Tests and linters / Tests with -race (pull_request) Successful in 6m5s
9a9de42aaf
* `SignRequestPrivateKey` field should be initialized either within
  `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all
  requests are signed by local node key that makes impossible to perform
  patch on non-container node.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin changed title from [#XX] object: Make patch not set key before target construction to object: Make patch not set key before target construction 2024-10-29 14:21:05 +00:00
aarifullin requested review from storage-core-committers 2024-10-29 14:21:17 +00:00
aarifullin requested review from storage-core-developers 2024-10-29 14:21:22 +00:00
aarifullin force-pushed fix/patch/sign from 9a9de42aaf to 8a6c341b4d 2024-10-29 14:38:25 +00:00 Compare
Owner

Do we already have any tests for this? If yes, please, extend them.

Do we already have any tests for this? If yes, please, extend them.
fyrchik approved these changes 2024-10-29 14:55:41 +00:00
dstepanov-yadro approved these changes 2024-10-29 15:18:58 +00:00
acid-ant approved these changes 2024-10-29 15:19:40 +00:00
dstepanov-yadro merged commit 87ac3c5279 into master 2024-10-29 15:20:29 +00:00
Sign in to join this conversation.
No reviewers
TrueCloudLab/storage-core-developers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1458
No description provided.