TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

object: Make patch not set key before target construction #1458

Merged
dstepanov-yadro merged 1 commit from aarifullin/frostfs-node:fix/patch/sign into master 2024-10-29 15:20:29 +00:00
Conversation 1 Commits 1 Files changed 1 +3 -4
aarifullin commented 2024-10-29 14:20:43 +00:00
Member
Copy link
  • SignRequestPrivateKey field should be initialized either within newUntrustedTarget or within newTrustedTarget. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node.
* `SignRequestPrivateKey` field should be initialized either within `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all requests are signed by local node key that makes impossible to perform patch on non-container node.
aarifullin added the
bug
 label 2024-10-29 14:20:43 +00:00
aarifullin added 1 commit 2024-10-29 14:20:44 +00:00
[#XX] object: Make patch not set key before target construction
Some checks failed
Tests and linters / Run gofumpt (pull_request) Successful in 1m34s
Details
DCO action / DCO (pull_request) Failing after 1m47s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m57s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m9s
Details
Build / Build Components (pull_request) Successful in 3m24s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m19s
Details
Tests and linters / gopls check (pull_request) Successful in 3m40s
Details
Tests and linters / Lint (pull_request) Successful in 4m14s
Details
Tests and linters / Tests (pull_request) Successful in 5m19s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m5s
Details
9a9de42aaf 
* `SignRequestPrivateKey` field should be initialized either within
  `newUntrustedTarget` or within `newTrustedTarget`. Otherwise, all
  requests are signed by local node key that makes impossible to perform
  patch on non-container node.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin changed title from [#XX] object: Make patch not set key before target construction to object: Make patch not set key before target construction 2024-10-29 14:21:05 +00:00
aarifullin requested review from storage-core-committers 2024-10-29 14:21:17 +00:00
aarifullin requested review from storage-core-developers 2024-10-29 14:21:22 +00:00
aarifullin force-pushed fix/patch/sign from 9a9de42aaf to 8a6c341b4d 2024-10-29 14:38:25 +00:00 Compare
fyrchik commented 2024-10-29 14:55:36 +00:00
Owner
Copy link

Do we already have any tests for this? If yes, please, extend them.

Do we already have any tests for this? If yes, please, extend them.
fyrchik approved these changes 2024-10-29 14:55:41 +00:00
dstepanov-yadro approved these changes 2024-10-29 15:18:58 +00:00
acid-ant approved these changes 2024-10-29 15:19:40 +00:00
dstepanov-yadro merged commit 87ac3c5279 into master 2024-10-29 15:20:29 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
acid-ant
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1458
No description provided.
Delete branch "aarifullin/frostfs-node:fix/patch/sign"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?