TrueCloudLab/frostfs-node
20
1
Fork 27
Code Issues 100 Pull requests 4 Projects Releases 1 Activity Actions

Tracing attributes #1488

Merged
fyrchik merged 1 commit from dstepanov-yadro/frostfs-node:feat/tracing_attrs into master 2024-11-20 15:43:54 +00:00
Conversation 1 Commits 1 Files changed 1 +1 -2
dstepanov-yadro commented 2024-11-12 08:38:00 +00:00
Member
Copy link

This allows to specify key-value attributes for all spans.

Example:
image

This allows to specify key-value attributes for all spans. Example: ![image](/attachments/a58db042-afc8-404b-91b9-f424ba52516c)
image.png
194 KiB
dstepanov-yadro added 4 commits 2024-11-12 08:38:01 +00:00 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
[#9999] Makefile: Drop all containers created on env-up
Some checks failed
Tests and linters / Tests with -race (pull_request) Failing after 1m27s
Details
Vulncheck / Vulncheck (pull_request) Failing after 1m26s
Details
DCO action / DCO (pull_request) Successful in 1m47s
Details
Tests and linters / Tests (pull_request) Failing after 1m49s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 1m48s
Details
Build / Build Components (pull_request) Failing after 2m2s
Details
Tests and linters / Staticcheck (pull_request) Failing after 1m57s
Details
Pre-commit hooks / Pre-commit (pull_request) Failing after 2m12s
Details
Tests and linters / Lint (pull_request) Failing after 2m38s
Details
Tests and linters / gopls check (pull_request) Failing after 2m48s
Details
4b6123c4c4 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
dstepanov-yadro force-pushed feat/tracing_attrs from 4b6123c4c4 to 933a1b577d 2024-11-12 09:04:54 +00:00 Compare
dstepanov-yadro force-pushed feat/tracing_attrs from 933a1b577d to 8c0714cd40 2024-11-12 09:42:46 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2024-11-12 10:31:05 +00:00
dstepanov-yadro requested review from storage-core-developers 2024-11-12 10:31:06 +00:00
dstepanov-yadro changed title from WIP: Tracing attributes to Tracing attributes 2024-11-12 10:31:23 +00:00
acid-ant approved these changes 2024-11-12 11:18:42 +00:00
Dismissed
fyrchik reviewed 2024-11-12 11:55:22 +00:00
fyrchik left a comment
Owner
Copy link

Please, use go.mod: as prefix for the first commit, as we already do, without inventing something new.

Please, use `go.mod:` as prefix for the first commit, as we already do, without inventing something new.
config/example/node.json Outdated
@ -261,3 +261,2 @@
"endpoint": "localhost:9090",
"endpoint": "localhost",
"exporter": "otlp_grpc",
"trusted_ca": "/etc/ssl/tracing.pem"
fyrchik commented 2024-11-12 11:54:05 +00:00
Owner
Copy link

trusted_ca and endpoint changes seem unrelated to the commit.

`trusted_ca` and `endpoint` changes seem unrelated to the commit.
fyrchik commented 2024-11-12 11:55:58 +00:00
Owner
Copy link

Oh, so we had them here, but they were not tested, am I right?

Oh, so we had them here, but they were not tested, am I right?
dstepanov-yadro commented 2024-11-12 14:17:16 +00:00
Author
Member
Copy link

This config was not covered by tests, so it is required to change the examples to write the tests.

This config was not covered by tests, so it is required to change the examples to write the tests.
fyrchik marked this conversation as resolved
fyrchik approved these changes 2024-11-12 12:11:18 +00:00
Dismissed
fyrchik reviewed 2024-11-12 12:17:17 +00:00
dev/docker-compose.yml Outdated
@ -17,0 +25,4 @@
environment:
- COLLECTOR_OTLP_ENABLED=true
- SPAN_STORAGE_TYPE=badger
- BADGER_EPHEMERAL=false
fyrchik commented 2024-11-12 12:17:14 +00:00
Owner
Copy link

I was under impression, that BADGER_EPHEMERAL uses temporary file-system, which is exactly what you do below, although explicitly.
Why not just use true here?

I was under impression, that `BADGER_EPHEMERAL` uses temporary file-system, which is exactly what you do below, although explicitly. Why not just use `true` here?
dstepanov-yadro commented 2024-11-12 14:25:50 +00:00
Author
Member
Copy link

copy-pasted from dev-env, but in dev-env repository persisted volume was used.

copy-pasted from dev-env, but in dev-env repository persisted volume was used.
dstepanov-yadro commented 2024-11-12 14:25:56 +00:00
Author
Member
Copy link

fixed

fixed
fyrchik marked this conversation as resolved
dstepanov-yadro force-pushed feat/tracing_attrs from 8c0714cd40 to f1556e3c42 2024-11-12 14:25:05 +00:00 Compare
dstepanov-yadro dismissed acid-ant's review 2024-11-12 14:25:05 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro dismissed fyrchik's review 2024-11-12 14:25:05 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

dstepanov-yadro commented 2024-11-12 14:26:28 +00:00
Author
Member
Copy link

Please, use go.mod: as prefix for the first commit, as we already do, without inventing something new.

I trusted autofill:( fixed

> Please, use `go.mod:` as prefix for the first commit, as we already do, without inventing something new. I trusted autofill:( fixed
dstepanov-yadro requested review from fyrchik 2024-11-12 14:32:54 +00:00
dstepanov-yadro requested review from acid-ant 2024-11-12 14:32:59 +00:00
fyrchik approved these changes 2024-11-12 19:07:51 +00:00
fyrchik merged commit f1556e3c42 into master 2024-11-13 06:49:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1488
No description provided.
Delete branch "dstepanov-yadro/frostfs-node:feat/tracing_attrs"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?