[#128] IR: Do not try to emit GAS to nobody #151

carpawell · 2023-03-20T17:00:13Z

carpawell commented

2023-03-20 17:00:13 +00:00

Fix sending GAS to an empty extra wallets receivers list. Also, send GAS to
extra wallets even if netmap is empty.

Signed-off-by: Pavel Karpy p.karpy@yadro.com

Saw

2023-03-20T16:43:02.447Z        warn    alphabet/process_emit.go:89     can't transfer gas to wallet    {"receivers": [], "amount": 250000000, "error": "at least one transfer parameter required"}

in logs.

Fix sending GAS to an empty extra wallets receivers list. Also, send GAS to extra wallets even if netmap is empty. Signed-off-by: Pavel Karpy <p.karpy@yadro.com> Saw ``` 2023-03-20T16:43:02.447Z warn alphabet/process_emit.go:89 can't transfer gas to wallet {"receivers": [], "amount": 250000000, "error": "at least one transfer parameter required"} ``` in logs.

👍 1

carpawell self-assigned this 2023-03-20 17:00:13 +00:00

carpawell requested review from storage-core-committers 2023-03-20 17:00:37 +00:00

carpawell requested review from storage-core-developers 2023-03-20 17:00:37 +00:00

carpawell requested review from ironbee 2023-03-20 17:00:41 +00:00

ironbee reviewed 2023-03-20 17:35:06 +00:00

pkg/innerring/processors/alphabet/process_emit.go Outdated

													
				@ -72,2 +87,3 @@

					}

						err = ap.morphClient.TransferGas(key.GetScriptHash(), gasPerNode)

					if extraLen != 0 {

ironbee commented

2023-03-20 17:35:06 +00:00

I had this condition initially but lost it in transition to batch processing. 👽

ironbee approved these changes 2023-03-20 17:35:09 +00:00

acid-ant approved these changes 2023-03-20 17:47:23 +00:00

fyrchik reviewed 2023-03-21 07:30:17 +00:00

pkg/innerring/processors/alphabet/process_emit.go Outdated

													
				@ -71,1 +83,4 @@

							}

						}

					} else {

						ap.log.Debug("gas emission: empty network map")

fyrchik commented

2023-03-21 07:30:07 +00:00

Can we use 1 log message like Debug("gas emission", zap.Int("network_map", nmLen), zap.Int("extra", extraLen)) instead on 3 (2 in else and 1 if both are 0).

Can we use 1 log message like `Debug("gas emission", zap.Int("network_map", nmLen), zap.Int("extra", extraLen))` instead on 3 (2 in `else` and 1 if both are 0).

carpawell commented

2023-03-21 07:51:45 +00:00

Poster

fixed

carpawell commented

2023-03-21 07:51:51 +00:00

Poster

fixed