TrueCloudLab/frostfs-node

Fork 27

Small refactorings for adm/helper package #1522

Merged

fyrchik merged 11 commits from fyrchik/frostfs-node:local-actor into master

2024-11-26 08:13:36 +00:00

fyrchik commented

2024-11-25 11:38:31 +00:00

Owner

Unexport function that aren't used outside the package.
Remove unused code.
Make constructor naming more precise and matching between local/remote scenario.

1. Unexport function that aren't used outside the package. 2. Remove unused code. 3. Make constructor naming more precise and matching between local/remote scenario.

fyrchik added 11 commits 2024-11-25 11:38:32 +00:00

adm: Remove unnecessary variable declaration a8800a96f5

It is better to have small scope.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Remove unused GetCommittee() method from the Client interface 1cfc473709

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Simplify Client interface a2a1f5b8f6

Just reuse `actor.RPCActor`. No functional changes.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm: Split NewLocalClient() into functions 18ca9c96bc

No functional changes.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm: Simplify LocalClient.SendRawTransaction() 3c4fefceb4

The old code was there before Copy() method was introduced.
It was also supposed to check errors, however, they are already checked
server-side.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Unexport GetFrostfsIDAdmin() 664ad39bc4

It is used in `helper` package only, besides unit-tests.
Move unit-tests to the same package, where they belong.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Rename GetN3Client() -> NewRemoteClient() 6154f0cf8c

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Remove NewActor() helper 7eecfdf719

It is used once, it is used only internally and it is single-statement.
I see no justification in having it as a separate function.
It introduces confusion, because we also have NewLocalActor().

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Unexport DefaultClientContext() d129f31a21

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/helper: Rename createSingleAccounts() -> getSingleAccounts() 50945caf57

It doesn't create any accounts, purely finds them in the wallet.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

adm/frostfsid: Remove unreachable condition

DCO action / DCO (pull_request) Failing after 1m37s

Details

Tests and linters / Run gofumpt (pull_request) Successful in 1m49s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m41s

Details

Build / Build Components (pull_request) Successful in 3m20s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 3m22s

Details

Tests and linters / gopls check (pull_request) Successful in 4m6s

Details

Tests and linters / Staticcheck (pull_request) Successful in 4m27s

Details

Tests and linters / Lint (pull_request) Successful in 4m59s

Details

Tests and linters / Tests (pull_request) Successful in 6m29s

Details

Tests and linters / Tests with -race (pull_request) Successful in 7m10s

Details

4a19ed5565

SendConsensusTx() modifies SendTxs field, if it is not the case, there
is a bug in code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik requested review from storage-core-committers 2024-11-25 11:40:22 +00:00

fyrchik requested review from storage-core-developers 2024-11-25 11:40:24 +00:00

fyrchik added the

frostfs-adm

internal

refactoring

labels 2024-11-25 11:40:56 +00:00

fyrchik added this to the v0.45.0 milestone 2024-11-25 11:40:58 +00:00

fyrchik force-pushed local-actor from 4a19ed5565 to 0f3ed39bf9

2024-11-25 13:23:43 +00:00

Compare