TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 4 Projects Releases 2 Activity Actions

metabase: Remove (*DB).IterateCoveredByTombstones #1526

Merged
dstepanov-yadro merged 1 commit from a-savchuk/frostfs-node:remove-unused-metabase-method into master 2024-11-29 13:19:32 +00:00
Conversation 0 Commits 1 Files changed 2 -128
a-savchuk commented 2024-11-28 07:45:04 +00:00
Member
Copy link

Close #1523

Remove this method because it isn't used anywhere since 7799f8e4c

Close #1523 Remove this method because it isn't used anywhere since 7799f8e4c
a-savchuk added 1 commit 2024-11-28 07:45:05 +00:00
[#1523] metabase: Remove (*DB).IterateCoveredByTombstones
All checks were successful
Tests and linters / Run gofumpt (pull_request) Successful in 2m10s
Details
DCO action / DCO (pull_request) Successful in 2m28s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 2m48s
Details
Vulncheck / Vulncheck (pull_request) Successful in 2m56s
Details
Build / Build Components (pull_request) Successful in 3m24s
Details
Tests and linters / gopls check (pull_request) Successful in 3m31s
Details
Tests and linters / Staticcheck (pull_request) Successful in 3m46s
Details
Tests and linters / Lint (pull_request) Successful in 4m42s
Details
Tests and linters / Tests (pull_request) Successful in 5m34s
Details
Tests and linters / Tests with -race (pull_request) Successful in 5m56s
Details
719e7ed08f 
Remove this method because it isn't used anywhere since 7799f8e4c.

Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
fyrchik approved these changes 2024-11-28 07:50:42 +00:00
a-savchuk requested review from storage-core-committers 2024-11-28 07:50:53 +00:00
fyrchik requested review from storage-core-developers 2024-11-28 07:50:59 +00:00
a-savchuk force-pushed remove-unused-metabase-method from 719e7ed08f to d791b1165d 2024-11-28 07:51:31 +00:00 Compare
a-savchuk force-pushed remove-unused-metabase-method from d791b1165d to e0ac3a583f 2024-11-29 10:49:27 +00:00 Compare
dstepanov-yadro approved these changes 2024-11-29 13:19:22 +00:00
dstepanov-yadro merged commit e0ac3a583f into master 2024-11-29 13:19:32 +00:00
a-savchuk deleted branch remove-unused-metabase-method 2024-11-29 13:32:51 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1526
No description provided.
Delete branch "a-savchuk/frostfs-node:remove-unused-metabase-method"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?