TrueCloudLab/frostfs-node

Fork 27

[SUPPORT] Fix error for APE check #1534

Merged

fyrchik merged 2 commits from aarifullin/frostfs-node:fix/ape_err into support/v0.44

2024-12-04 07:34:36 +00:00

aarifullin commented

2024-12-04 06:59:31 +00:00

Member

Common APE checking logic was moved into a common package but CheckAPE has been returning the error wrapped into apistatus. That leads to this effect:

$ frostfs-cli container list-objects -w wallet.json -r localhost:8080 --cid CVoGbSRn4CJFReL2mDVTma7
MuRg1pmDDZmMYwRXVndF2 | head
Enter password >
rpc error: read object list: status: code = 2048 message = access to object operation denied: ape denied request: status: code = 2048 message = access to object operation denied

So:

The error is not wrapped to apistatus in common package
Tree service wraps it on its own
Object service already does this on its own - no change is required

Common APE checking logic was moved into a common package but `CheckAPE` has been returning the error wrapped into `apistatus`. That leads to this effect: ```bash $ frostfs-cli container list-objects -w wallet.json -r localhost:8080 --cid CVoGbSRn4CJFReL2mDVTma7 MuRg1pmDDZmMYwRXVndF2 | head Enter password > rpc error: read object list: status: code = 2048 message = access to object operation denied: ape denied request: status: code = 2048 message = access to object operation denied ``` So: - The error is not wrapped to `apistatus` in `common` package - Tree service wraps it on its own - Object service already does this on its own - no change is required

aarifullin added 2 commits 2024-12-04 06:59:32 +00:00

[#1524 ] ape: Make APE checker return error without status 274ac61236

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

[#1524 ] tree: Make check APE error get wrapped to api status

Tests and linters / Run gofumpt (pull_request) Successful in 2m11s

Details

DCO action / DCO (pull_request) Successful in 2m26s

Details

Vulncheck / Vulncheck (pull_request) Successful in 2m37s

Details

Pre-commit hooks / Pre-commit (pull_request) Successful in 2m55s

Details

Build / Build Components (pull_request) Successful in 3m21s

Details

Tests and linters / gopls check (pull_request) Successful in 3m25s

Details

Tests and linters / Staticcheck (pull_request) Successful in 3m55s

Details

Tests and linters / Lint (pull_request) Successful in 4m36s

Details

Tests and linters / Tests (pull_request) Successful in 5m1s

Details

Tests and linters / Tests with -race (pull_request) Successful in 6m4s

Details

cf48dfd55e

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

acid-ant approved these changes 2024-12-04 07:02:12 +00:00

dstepanov-yadro approved these changes 2024-12-04 07:05:20 +00:00

fyrchik approved these changes 2024-12-04 07:34:29 +00:00

fyrchik merged commit cf48dfd55e into support/v0.44

2024-12-04 07:34:36 +00:00

No reviewers

No labels

No milestone

No project

No assignees

4 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1534

No description provided.