TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 104 Pull requests 6 Projects Releases 2 Activity Actions

network/cache: Add node address to error multiClient #1562

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:feat/multinet_err2 into master 2024-12-19 06:45:33 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/network/cache/multi.go vendored
View file

@ -155,7 +155,7 @@ func (x *multiClient) iterateClients(ctx context.Context, f func(clientcore.Clie
group.IterateAddresses(func(addr network.Address) bool { group.IterateAddresses(func(addr network.Address) bool {
select { select {
case <-ctx.Done(): case <-ctx.Done():
firstErr = context.Canceled firstErr = fmt.Errorf("try %v: %w", addr, context.Canceled)
achuprov marked this conversation as resolved Outdated
aarifullin commented 2024-12-16 07:43:25 +00:00
Outdated
Review
Copy link

This error doesn't seem to be client connection error as you're not establishing any connection yet at this moment - this is performed below.

So, how about?

firstErr = fmt.Errorf("unable to proceed with client iteration at %v: %w", addr, context.Canceled)
This error doesn't seem to be `client connection` error as you're not establishing any connection yet at this moment - this is performed below. So, how about? ```go firstErr = fmt.Errorf("unable to proceed with client iteration at %v: %w", addr, context.Canceled) ```
fyrchik commented 2024-12-16 08:22:06 +00:00
Outdated
Review
Copy link

How about just try %v: %w?

How about just `try %v: %w`?
👍 2
achuprov commented 2024-12-18 16:36:02 +00:00
Outdated
Review
Copy link

@fyrchik fixed

@fyrchik fixed
return true return true
default: default:
} }