TrueCloudLab/frostfs-node
21
1
Fork 27
Code Issues 107 Pull requests 3 Projects Releases 2 Activity Actions

network/cache: Add node address to error multiClient #1562

Merged
fyrchik merged 1 commit from achuprov/frostfs-node:feat/multinet_err2 into master 2024-12-19 06:45:33 +00:00
Conversation 0 Commits 1 Files changed 1 +1 -1
achuprov commented 2024-12-13 16:16:36 +00:00
Member
Copy link

#1342
context canceled is also an error that requires to add the node address.
Signed-off-by: Alexander Chuprov a.chuprov@yadro.com

#1342 `context canceled` is also an error that requires to add the node address. Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov added 1 commit 2024-12-13 16:16:37 +00:00
[#1342] network/cache: Add node address to error multiClient
All checks were successful
Vulncheck / Vulncheck (pull_request) Successful in 2m51s
Details
Pre-commit hooks / Pre-commit (pull_request) Successful in 3m17s
Details
Tests and linters / gopls check (pull_request) Successful in 3m44s
Details
Tests and linters / Run gofumpt (pull_request) Successful in 4m52s
Details
DCO action / DCO (pull_request) Successful in 5m4s
Details
Build / Build Components (pull_request) Successful in 6m15s
Details
Tests and linters / Tests (pull_request) Successful in 6m30s
Details
Tests and linters / Tests with -race (pull_request) Successful in 6m30s
Details
Tests and linters / Staticcheck (pull_request) Successful in 6m31s
Details
Tests and linters / Lint (pull_request) Successful in 7m14s
Details
7320396c5f 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
achuprov requested review from storage-core-committers 2024-12-13 16:16:37 +00:00
achuprov requested review from storage-core-developers 2024-12-13 16:16:37 +00:00
aarifullin reviewed 2024-12-16 07:43:26 +00:00
pkg/network/cache/multi.go Outdated
@ -156,3 +156,3 @@
select {
case <-ctx.Done():
firstErr = context.Canceled
firstErr = fmt.Errorf("client connection error at %v: %w", addr, context.Canceled)
aarifullin commented 2024-12-16 07:43:25 +00:00
Member
Copy link

This error doesn't seem to be client connection error as you're not establishing any connection yet at this moment - this is performed below.

So, how about?

firstErr = fmt.Errorf("unable to proceed with client iteration at %v: %w", addr, context.Canceled)
This error doesn't seem to be `client connection` error as you're not establishing any connection yet at this moment - this is performed below. So, how about? ```go firstErr = fmt.Errorf("unable to proceed with client iteration at %v: %w", addr, context.Canceled) ```
fyrchik commented 2024-12-16 08:22:06 +00:00
Owner
Copy link

How about just try %v: %w?

How about just `try %v: %w`?
👍 2
achuprov commented 2024-12-18 16:36:02 +00:00
Author
Member
Copy link

@fyrchik fixed

@fyrchik fixed
achuprov marked this conversation as resolved
achuprov force-pushed feat/multinet_err2 from 7320396c5f to b0ccf592be 2024-12-18 16:27:25 +00:00 Compare
achuprov force-pushed feat/multinet_err2 from b0ccf592be to 51ee132ea3 2024-12-18 16:27:48 +00:00 Compare
fyrchik approved these changes 2024-12-19 06:45:27 +00:00
fyrchik merged commit 51ee132ea3 into master 2024-12-19 06:45:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
badger

Badger DB related issues

  
frostfs-adm

   
frostfs-cli

   
frostfs-ir

   
frostfs-lens

   
frostfs-node

   
good first issue

Good for newcomers

  
triage
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
badger
frostfs-adm
frostfs-cli
frostfs-ir
frostfs-lens
frostfs-node
good first issue
triage
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-node#1562
No description provided.
Delete branch "achuprov/frostfs-node:feat/multinet_err2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?